Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2340253003: Revert of Add arraysize to rtc_base_approved. Remove dependency of audio_device on rtc_base. (Closed)

Created:
4 years, 3 months ago by Max Morin WebRTC
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add arraysize to rtc_base_approved. Remove dependency of audio_device on rtc_base. (patchset #1 id:1 of https://codereview.webrtc.org/2346763002/ ) Reason for revert: Breaks iOS Original issue's description: > Add arraysize to rtc_base_approved. Remove dependency of audio_device on rtc_base. > > BUG=webrtc:3806 > NOTRY=True > > Committed: https://crrev.com/100c9d02669910bce06099b3cc1eaad60fd661dd > Cr-Commit-Position: refs/heads/master@{#14223} TBR=kjellander@webrtc.org,henrika@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:3806 Committed: https://crrev.com/89fb9201b70616a1c33e277f38bf9367112536e8 Cr-Commit-Position: refs/heads/master@{#14224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M webrtc/base/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/base/base.gyp View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Max Morin WebRTC
Created Revert of Add arraysize to rtc_base_approved. Remove dependency of audio_device on rtc_base.
4 years, 3 months ago (2016-09-15 08:45:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2340253003/1
4 years, 3 months ago (2016-09-15 08:45:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 08:45:27 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/89fb9201b70616a1c33e277f38bf9367112536e8 Cr-Commit-Position: refs/heads/master@{#14224}
4 years, 3 months ago (2016-09-15 08:45:41 UTC) #6
Max Morin WebRTC
On 2016/09/15 08:45:10, Max Morin wrote: > Created Revert of Add arraysize to rtc_base_approved. Remove ...
4 years, 3 months ago (2016-09-15 08:45:41 UTC) #7
kjellander_webrtc
On 2016/09/15 08:45:41, Max Morin wrote: > On 2016/09/15 08:45:10, Max Morin wrote: > > ...
4 years, 3 months ago (2016-09-15 09:13:55 UTC) #8
Max Morin WebRTC
On 2016/09/15 09:13:55, kjellander_webrtc wrote: > On 2016/09/15 08:45:41, Max Morin wrote: > > On ...
4 years, 3 months ago (2016-09-15 09:23:40 UTC) #9
kjellander_webrtc
On 2016/09/15 09:23:40, Max Morin wrote: > On 2016/09/15 09:13:55, kjellander_webrtc wrote: > > On ...
4 years, 3 months ago (2016-09-15 09:43:47 UTC) #10
Max Morin WebRTC
4 years, 3 months ago (2016-09-15 10:46:27 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2340233003/ by maxmorin@webrtc.org.

The reason for reverting is: Fix: let audio_device depend on rtc_base on IOS..

Powered by Google App Engine
This is Rietveld 408576698