Adding SmoothingFilter to audio network adaptor.

Adding SmoothingFilter to audio network adaptor.

BUG=webrtc:6303
Committed: https://crrev.com/3548357e1bf2450d0240bf938723e4927afb5c1c
Cr-Commit-Position: refs/heads/master@{#14313}

[minyue-webrtc, 2016-09-13 15:22:39]

Description was changed from

==========
Adding SmoothingFilter to audio network adaptor.

BUG=webrtc:6303
==========

to

==========
Adding SmoothingFilter to audio network adaptor.

BUG=webrtc:6303
==========

[minyue-webrtc, 2016-09-13 15:22:40]

minyue@webrtc.org changed reviewers:
+ michaelt@webrtc.org

[minyue-webrtc, 2016-09-13 15:23:05]

Hi Michael,

Please take a look at this CL. Thank you!

[michaelt, 2016-09-16 08:45:52]

lgtm

[minyue-webrtc, 2016-09-16 08:46:42]

minyue@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[minyue-webrtc, 2016-09-16 08:51:18]

Hi Henrik,

This is a CL that the FEC controller, which you are reviewing, replies on.

Michael has given a look. Now I send it to you to give another look.

https://codereview.webrtc.org/2339523002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/audio_network_adaptor/smoothing_filter.cc
(right):

https://codereview.webrtc.org/2339523002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/audio_network_adaptor/smoothing_filter.cc:11:
#include <cmath>
will move this after "smoothing_filter.h"

[hlundin-webrtc, 2016-09-19 15:04:38]

lgtm

https://codereview.webrtc.org/2339523002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/audio_network_adaptor/smoothing_filter.h
(right):

https://codereview.webrtc.org/2339523002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/audio_network_adaptor/smoothing_filter.h:41: Clock*
const clock_;
I think you can double-const this:
const Clock* const clock_;  // Both the pointer and the object pointed to are
const.

https://codereview.webrtc.org/2339523002/diff/20001/webrtc/modules/audio_codi...
File
webrtc/modules/audio_coding/audio_network_adaptor/smoothing_filter_unittest.cc
(right):

https://codereview.webrtc.org/2339523002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/audio_network_adaptor/smoothing_filter_unittest.cc:55:
// Python script to calculate the reference values used in this test.
Nice!

[minyue-webrtc, 2016-09-20 12:11:42]

The CQ bit was checked by minyue@webrtc.org

[minyue-webrtc, 2016-09-20 12:11:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org, michaelt@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2339523002/#ps40001 (title:
"rebasing")

[minyue-webrtc, 2016-09-20 12:11:50]

The CQ bit was unchecked by minyue@webrtc.org

[minyue-webrtc, 2016-09-20 12:14:41]

The CQ bit was checked by minyue@webrtc.org

[minyue-webrtc, 2016-09-20 12:14:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org, michaelt@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2339523002/#ps60001 (title:
"adding const qualifier to Clock*")

[commit-bot: I haz the power, 2016-09-20 12:14:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-20 12:21:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 12:21:27]

Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/14516)

[minyue-webrtc, 2016-09-20 12:50:39]

The CQ bit was checked by minyue@webrtc.org

[minyue-webrtc, 2016-09-20 12:50:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org, michaelt@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2339523002/#ps100001 (title:
"small polish")

[commit-bot: I haz the power, 2016-09-20 12:50:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-20 14:51:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 14:51:15]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_clang_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_drmemory_light on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_x64_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_x64_clang_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_x64_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_x64_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_x64_gyp_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_x64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[minyue-webrtc, 2016-09-20 15:03:12]

The CQ bit was checked by minyue@webrtc.org

[commit-bot: I haz the power, 2016-09-20 15:03:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-20 17:03:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 17:03:51]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_x64_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_x64_gyp_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[minyue-webrtc, 2016-09-20 20:47:34]

The CQ bit was checked by minyue@webrtc.org

[minyue-webrtc, 2016-09-20 20:47:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org, michaelt@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2339523002/#ps120001 (title:
"fixing a gyp error")

[commit-bot: I haz the power, 2016-09-20 20:47:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-20 21:26:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 21:26:35]

Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/16899)

[minyue-webrtc, 2016-09-21 04:57:00]

The CQ bit was checked by minyue@webrtc.org

[commit-bot: I haz the power, 2016-09-21 04:57:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-21 06:13:13]

Description was changed from

==========
Adding SmoothingFilter to audio network adaptor.

BUG=webrtc:6303
==========

to

==========
Adding SmoothingFilter to audio network adaptor.

BUG=webrtc:6303
==========

[commit-bot: I haz the power, 2016-09-21 06:13:15]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-21 06:13:19]

Description was changed from

==========
Adding SmoothingFilter to audio network adaptor.

BUG=webrtc:6303
==========

to

==========
Adding SmoothingFilter to audio network adaptor.

BUG=webrtc:6303

Committed: https://crrev.com/3548357e1bf2450d0240bf938723e4927afb5c1c
Cr-Commit-Position: refs/heads/master@{#14313}
==========

[commit-bot: I haz the power, 2016-09-21 06:13:20]

Patchset 7 (id:??) landed as
https://crrev.com/3548357e1bf2450d0240bf938723e4927afb5c1c
Cr-Commit-Position: refs/heads/master@{#14313}