Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2339363002: Deprecate RtpSender::SendPadData with provided timestamps. (Closed)

Created:
4 years, 3 months ago by danilchap
Modified:
4 years, 3 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Deprecate RtpSender::SendPadData with provided timestamps. Committed: https://crrev.com/7bfe3a27b62cafc38ab34524cc3a06fad29c2596 Cr-Commit-Position: refs/heads/master@{#14287}

Patch Set 1 #

Patch Set 2 : Include what you use #

Patch Set 3 : nits #

Total comments: 2

Patch Set 4 : Hide non-deprecated version of SendPadData #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -18 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 2 3 3 chunks +10 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 2 chunks +12 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
danilchap
4 years, 3 months ago (2016-09-15 12:54:22 UTC) #3
stefan-webrtc
https://codereview.webrtc.org/2339363002/diff/60001/webrtc/modules/rtp_rtcp/source/rtp_sender.h File webrtc/modules/rtp_rtcp/source/rtp_sender.h (right): https://codereview.webrtc.org/2339363002/diff/60001/webrtc/modules/rtp_rtcp/source/rtp_sender.h#newcode275 webrtc/modules/rtp_rtcp/source/rtp_sender.h:275: size_t SendPadData(size_t bytes, int probe_cluster_id); Can this be made ...
4 years, 3 months ago (2016-09-15 13:02:02 UTC) #4
danilchap
https://codereview.webrtc.org/2339363002/diff/60001/webrtc/modules/rtp_rtcp/source/rtp_sender.h File webrtc/modules/rtp_rtcp/source/rtp_sender.h (right): https://codereview.webrtc.org/2339363002/diff/60001/webrtc/modules/rtp_rtcp/source/rtp_sender.h#newcode275 webrtc/modules/rtp_rtcp/source/rtp_sender.h:275: size_t SendPadData(size_t bytes, int probe_cluster_id); On 2016/09/15 13:02:02, stefan-webrtc ...
4 years, 3 months ago (2016-09-15 14:22:42 UTC) #5
stefan-webrtc
lgtm
4 years, 3 months ago (2016-09-19 08:50:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2339363002/80001
4 years, 3 months ago (2016-09-19 12:26:45 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 3 months ago (2016-09-19 12:37:59 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 12:38:12 UTC) #11
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/7bfe3a27b62cafc38ab34524cc3a06fad29c2596
Cr-Commit-Position: refs/heads/master@{#14287}

Powered by Google App Engine
This is Rietveld 408576698