Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2338813002: Remove dependency of audio_device on metrics_default. (Closed)

Created:
4 years, 3 months ago by Max Morin WebRTC
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, henrika_webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove dependency of audio_device on metrics_default. BUG=webrtc:6349 NOTRY=True Committed: https://crrev.com/f8a4ecc4a188416aac76a6713f0ec0432f1ee49e Cr-Commit-Position: refs/heads/master@{#14205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M webrtc/modules/audio_device/audio_device.gypi View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Max Morin WebRTC
Kjellander: PTAL.
4 years, 3 months ago (2016-09-13 13:42:42 UTC) #3
kjellander_webrtc
lgtm please land with NOTRY=True but run a few compile-trybots manually.
4 years, 3 months ago (2016-09-13 13:50:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2338813002/1
4 years, 3 months ago (2016-09-14 07:12:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 07:20:27 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 07:20:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8a4ecc4a188416aac76a6713f0ec0432f1ee49e
Cr-Commit-Position: refs/heads/master@{#14205}

Powered by Google App Engine
This is Rietveld 408576698