Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2338493002: Reland of Introduced new scheme for controlling the functionality inside the audio processing module (Closed)

Created:
4 years, 3 months ago by peah-webrtc
Modified:
4 years, 3 months ago
Reviewers:
the sun, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

The current scheme for setting parameters and specifying the behavior of the audio processing module is quite complex and hard to implement in a threadsafe and efficient manner. Therefore a new scheme for setting the parameters in the audio processing module is introduced in this CL. The idea is to roll this scheme out gradually and as a first functionality in the audio processing module where this is applied the level controller was chosen. This CL includes the replacement of the Config-based level controller scheme with the new scheme. TBR=henrik.lundin@webrtc.org, solenberg@webrtc.org, BUG=webrtc:5298 Committed: https://crrev.com/88ac853e14e05d9caca8f2f7d9dd02a267eb540e Cr-Commit-Position: refs/heads/master@{#14190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -76 lines) Patch
M webrtc/media/engine/fakewebrtcvoiceengine.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.h View 4 chunks +8 lines, -8 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 5 chunks +34 lines, -18 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 5 chunks +28 lines, -13 lines 0 comments Download
M webrtc/modules/audio_processing/include/mock_audio_processing.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/level_controller/level_controller.h View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/level_controller/level_controller.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/level_controller/level_controller_unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/test/aec_dump_based_simulator.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/audio_processing_simulator.cc View 3 chunks +5 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/debug_dump_test.cc View 18 chunks +33 lines, -23 lines 0 comments Download
M webrtc/modules/audio_processing/test/process_test.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2338493002/1
4 years, 3 months ago (2016-09-12 21:39:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 23:47:28 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 23:47:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88ac853e14e05d9caca8f2f7d9dd02a267eb540e
Cr-Commit-Position: refs/heads/master@{#14190}

Powered by Google App Engine
This is Rietveld 408576698