Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2338233004: Make GN build screenshare_loopback (Closed)

Created:
4 years, 3 months ago by palmkvist
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make GN build screenshare_loopback BUG=None Committed: https://crrev.com/69034df0b0f2952d612e0b908d7593a497142739 Cr-Commit-Position: refs/heads/master@{#14702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M webrtc/BUILD.gn View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
palmkvist
4 years, 3 months ago (2016-09-15 12:01:02 UTC) #2
sprang_webrtc
lgtm stefan ptal
4 years, 2 months ago (2016-10-17 08:09:20 UTC) #3
stefan-webrtc
lgtm Add a BUG or enter None.
4 years, 2 months ago (2016-10-17 17:46:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2338233004/1
4 years, 2 months ago (2016-10-19 13:10:34 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on ...
4 years, 2 months ago (2016-10-19 15:11:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2338233004/1
4 years, 2 months ago (2016-10-20 09:28:46 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 11:03:29 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-20 11:03:39 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69034df0b0f2952d612e0b908d7593a497142739
Cr-Commit-Position: refs/heads/master@{#14702}

Powered by Google App Engine
This is Rietveld 408576698