Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2338133003: Let ViEEncoder tell VideoSendStream about reconfigurations. (Closed)

Created:
4 years, 3 months ago by perkj_webrtc
Modified:
4 years, 3 months ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, perkj_webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Let ViEEncoder tell VideoSendStream about reconfigurations. This cl change so that all encoder configuration changes are reported to VideoSendStream through the ViEEncoder. Also, the PayLoadRouter is changed to never stop sending on a an ssrc due to the encoder video frame size changes. Instead, the number of sending streams is only decided by the number of sending ssrc. This cl is a preparation for moving encoder reconfiguration due to input video frame size changes from WebRtcVideoSendStream to ViEEncoder. BUG=webrtc:5687, webrtc:6371 R=mflodman@webrtc.org Committed: https://crrev.com/512ecb320668bb1a70dd5bf56e6a5732a58f8743 Cr-Commit-Position: refs/heads/master@{#14371}

Patch Set 1 #

Patch Set 2 : Fix formatting. #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -126 lines) Patch
M webrtc/video/payload_router.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/video/payload_router.cc View 6 chunks +8 lines, -32 lines 0 comments Download
M webrtc/video/payload_router_unittest.cc View 5 chunks +0 lines, -23 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 2 3 16 chunks +68 lines, -39 lines 0 comments Download
M webrtc/video/vie_encoder.h View 1 2 3 4 chunks +15 lines, -4 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 1 2 3 4 chunks +15 lines, -5 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 1 2 3 7 chunks +65 lines, -20 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (10 generated)
perkj_webrtc
please?
4 years, 3 months ago (2016-09-14 13:33:17 UTC) #3
perkj_webrtc
ping
4 years, 3 months ago (2016-09-20 07:24:16 UTC) #6
perkj_webrtc
Guys, there is more than a week ago since I sent out this for review. ...
4 years, 3 months ago (2016-09-23 06:50:12 UTC) #7
mflodman
LGTM!
4 years, 3 months ago (2016-09-23 08:02:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2338133003/80001
4 years, 3 months ago (2016-09-23 09:07:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/10901)
4 years, 3 months ago (2016-09-23 09:10:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2338133003/80001
4 years, 3 months ago (2016-09-23 11:16:13 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_drmemory_light on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/builds/15291)
4 years, 3 months ago (2016-09-23 11:30:03 UTC) #16
perkj_webrtc
Committed patchset #4 (id:80001) manually as 512ecb320668bb1a70dd5bf56e6a5732a58f8743 (presubmit successful).
4 years, 3 months ago (2016-09-23 13:52:25 UTC) #18
perkj_webrtc
A revert of this CL (patchset #4 id:80001) has been created in https://codereview.webrtc.org/2364913002/ by perkj@webrtc.org. ...
4 years, 3 months ago (2016-09-23 14:04:16 UTC) #20
ehmaldonado_webrtc
4 years, 3 months ago (2016-09-23 14:35:05 UTC) #21
Message was sent while issue was closed.
On 2016/09/23 14:04:16, perkj_webrtc wrote:
> A revert of this CL (patchset #4 id:80001) has been created in
> https://codereview.webrtc.org/2364913002/ by mailto:perkj@webrtc.org.
> 
> The reason for reverting is: git cl land broke tests. 
> Should have done a clean rebase......

I get "No issue exists with that id (2364913002)" when I try to look at it.

Powered by Google App Engine
This is Rietveld 408576698