Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 2338033002: Android EglBase: Include EGL error code in exceptions (Closed)

Created:
4 years, 3 months ago by magjed_webrtc
Modified:
4 years, 3 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android EglBase: Include EGL error code in exceptions This CL appends the EGL error code in exceptions after an EGL function fails. This information is helpful when debugging. BUG=webrtc:6350 Committed: https://crrev.com/b471d1cffb880ad6bcf60a1e348073491b99e018 Cr-Commit-Position: refs/heads/master@{#14208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -16 lines) Patch
M webrtc/api/android/java/src/org/webrtc/EglBase10.java View 7 chunks +16 lines, -8 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/EglBase14.java View 7 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
magjed_webrtc
Sami - please take a look.
4 years, 3 months ago (2016-09-13 18:18:38 UTC) #3
sakal
lgtm
4 years, 3 months ago (2016-09-14 07:18:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2338033002/1
4 years, 3 months ago (2016-09-14 07:26:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 09:40:53 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 09:41:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b471d1cffb880ad6bcf60a1e348073491b99e018
Cr-Commit-Position: refs/heads/master@{#14208}

Powered by Google App Engine
This is Rietveld 408576698