Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: webrtc/BUILD.gn

Issue 2337463002: Fixed video_loopback target. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/BUILD.gn
diff --git a/webrtc/BUILD.gn b/webrtc/BUILD.gn
index c33055ce76cedc6c76c795c1fbf5a3aff4c73142..aeff072f5633cca61326bced3564fe1dafbcf6aa 100644
--- a/webrtc/BUILD.gn
+++ b/webrtc/BUILD.gn
@@ -293,32 +293,34 @@ if (!build_with_chromium) {
]
}
- rtc_executable("video_loopback") {
- testonly = true
- sources = [
- "test/run_test.h",
- "video/video_loopback.cc",
- ]
+ if (rtc_include_tests) {
+ rtc_executable("video_loopback") {
+ testonly = true
kjellander_webrtc 2016/09/13 09:21:25 Please move this target down to the already existi
charujain 2016/09/13 11:26:55 Done.
+ sources = [
+ "test/run_test.h",
+ "video/video_loopback.cc",
+ ]
- if (is_mac) {
- sources += [ "test/mac/run_test.mm" ]
- } else {
- sources += [ "test/run_test.cc" ]
- }
- deps = [
- ":video_quality_test",
- "system_wrappers:metrics_default",
- "test:field_trial",
- "test:test_common",
- "test:test_renderer",
- "//testing/gmock",
- "//testing/gtest",
- "//third_party/gflags",
- ]
- if (is_clang && !is_nacl) {
- # Suppress warnings from Chrome's Clang plugins.
- # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
- suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+ if (is_mac) {
+ sources += [ "test/mac/run_test.mm" ]
+ } else {
+ sources += [ "test/run_test.cc" ]
+ }
+ deps = [
+ ":video_quality_test",
+ "system_wrappers:metrics_default",
+ "test:field_trial",
+ "test:test_common",
+ "test:test_renderer",
+ "//testing/gmock",
+ "//testing/gtest",
+ "//third_party/gflags",
+ ]
+ if (is_clang && !is_nacl) {
+ # Suppress warnings from Chrome's Clang plugins.
+ # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+ suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+ }
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698