Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: webrtc/video/end_to_end_tests.cc

Issue 2337453002: H.264 packetization mode 0 (try 2) (Closed)
Patch Set: Working H.264 test where packetization mode 0 is set Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/end_to_end_tests.cc
diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc
index 1f8109fd8b639b3ee23a2e899b9eb9a973d419a1..c4df94f734891d91d10980bb67b04c33f2b6d0b6 100644
--- a/webrtc/video/end_to_end_tests.cc
+++ b/webrtc/video/end_to_end_tests.cc
@@ -374,7 +374,7 @@ TEST_F(EndToEndTest, SendsAndReceivesVP9VideoRotation90) {
}
#endif // !defined(RTC_DISABLE_VP9)
-#if defined(WEBRTC_END_TO_END_H264_TESTS)
+#if defined(WEBRTC_USE_H264)
TEST_F(EndToEndTest, SendsAndReceivesH264) {
CodecObserver test(500, kVideoRotation_0, "H264",
@@ -390,7 +390,19 @@ TEST_F(EndToEndTest, SendsAndReceivesH264VideoRotation90) {
RunBaseTest(&test);
}
-#endif // defined(WEBRTC_END_TO_END_H264_TESTS)
+TEST_F(EndToEndTest, SendsAndReceivesH264PacketizationMode0) {
hbos 2016/10/31 10:32:26 How big is a NAL and are we sure that this will tr
hta-webrtc 2016/10/31 15:03:04 The NALU limit is what's being set over in the h26
hbos 2016/10/31 16:27:15 Acknowledged.
+ VideoEncoder* encoder = VideoEncoder::Create(VideoEncoder::kH264);
+ VideoCodec codec_settings;
+ codec_settings.codecType = kVideoCodecH264;
+ codec_settings.H264()->packetization_mode = kH264PacketizationMode0;
+ encoder->InitEncode(&codec_settings, 0, 1024);
+ // The CodecObserver takes ownership of the encoder.
+ CodecObserver test(500, kVideoRotation_0, "H264", encoder,
+ H264Decoder::Create());
+ RunBaseTest(&test);
+}
hbos 2016/10/31 10:32:26 How about a test that explicitly runs with Mode1 w
hta-webrtc 2016/10/31 15:03:04 Added.
+
+#endif // defined(WEBRTC_USE_H264)
TEST_F(EndToEndTest, ReceiverUsesLocalSsrc) {
class SyncRtcpObserver : public test::EndToEndTest {

Powered by Google App Engine
This is Rietveld 408576698