Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2337283003: Merge RtcpReceive::Handle<Packet>Item functions into Handle<Packet> (Closed)

Created:
4 years, 3 months ago by danilchap
Modified:
4 years, 3 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Merge RtcpReceiver::Handle<Packet>Item functions into Handle<Packet> As a preparation to replace parsing implementation. BUG=webrtc:5260 R=philipel@webrtc.org Committed: https://crrev.com/530b3f5d06b873ca6ad72207b680260ed92afd44 Cr-Commit-Position: refs/heads/master@{#14240}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -177 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 1 5 chunks +0 lines, -35 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 1 9 chunks +103 lines, -142 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
danilchap
To make https://codereview.webrtc.org/2316093002/ more reviewable slicing out this change
4 years, 3 months ago (2016-09-14 11:46:04 UTC) #3
philipel
lgtm with a few nits https://codereview.webrtc.org/2337283003/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right): https://codereview.webrtc.org/2337283003/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc#newcode728 webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:728: assert(cnameInfo); RTC_CHECK https://codereview.webrtc.org/2337283003/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc#newcode734 webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:734: ...
4 years, 3 months ago (2016-09-15 15:30:00 UTC) #4
danilchap
https://codereview.webrtc.org/2337283003/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right): https://codereview.webrtc.org/2337283003/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc#newcode728 webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:728: assert(cnameInfo); On 2016/09/15 15:30:00, philipel wrote: > RTC_CHECK Done. ...
4 years, 3 months ago (2016-09-15 16:31:47 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/530b3f5d06b873ca6ad72207b680260ed92afd44 Cr-Commit-Position: refs/heads/master@{#14240}
4 years, 3 months ago (2016-09-15 16:41:17 UTC) #8
danilchap
4 years, 3 months ago (2016-09-15 16:41:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
530b3f5d06b873ca6ad72207b680260ed92afd44 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698