Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Side by Side Diff: webrtc/modules/audio_processing/level_controller/peak_level_estimator.h

Issue 2337083002: Reland of added functionality for specifying the initial signal level to use for the gain estimation (Closed)
Patch Set: Changed parameter name from initial_level to the more correct initial_peak_level Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_AUDIO_PROCESSING_LEVEL_CONTROLLER_PEAK_LEVEL_ESTIMATOR_H_ 11 #ifndef WEBRTC_MODULES_AUDIO_PROCESSING_LEVEL_CONTROLLER_PEAK_LEVEL_ESTIMATOR_H_
12 #define WEBRTC_MODULES_AUDIO_PROCESSING_LEVEL_CONTROLLER_PEAK_LEVEL_ESTIMATOR_H_ 12 #define WEBRTC_MODULES_AUDIO_PROCESSING_LEVEL_CONTROLLER_PEAK_LEVEL_ESTIMATOR_H_
13 13
14 #include "webrtc/base/constructormagic.h" 14 #include "webrtc/base/constructormagic.h"
15 #include "webrtc/base/gtest_prod_util.h"
16 #include "webrtc/modules/audio_processing/level_controller/lc_constants.h"
15 #include "webrtc/modules/audio_processing/level_controller/signal_classifier.h" 17 #include "webrtc/modules/audio_processing/level_controller/signal_classifier.h"
16 18
17 namespace webrtc { 19 namespace webrtc {
18 20
19 class PeakLevelEstimator { 21 class PeakLevelEstimator {
20 public: 22 public:
21 PeakLevelEstimator(); 23 PeakLevelEstimator();
22 ~PeakLevelEstimator(); 24 ~PeakLevelEstimator();
23 void Initialize(); 25 void Initialize();
24 float Analyze(SignalClassifier::SignalType signal_type, 26 float Analyze(SignalClassifier::SignalType signal_type,
25 float frame_peak_level); 27 float frame_peak_level);
28 // Sets the initial peak level to use inside the level controller in order
29 // to compute the signal gain. The unit for the peak level is dBFS and
30 // the allowed range is [-100, 0].
31 void SetInitialPeakLevel(float level);
26 32
27 private: 33 private:
34 FRIEND_TEST_ALL_PREFIXES(LevelControllerConfig, InitialLevel);
28 float peak_level_; 35 float peak_level_;
36 float initial_peak_level_ = kTargetLcPeakLevel;
the sun 2016/09/16 12:40:25 Is this default value really needed? Won't it be s
peah-webrtc 2016/09/19 16:37:10 Not in the way it is now, as it basically constitu
29 int hold_counter_; 37 int hold_counter_;
30 bool initialization_phase_; 38 bool initialization_phase_;
31 39
32 RTC_DISALLOW_COPY_AND_ASSIGN(PeakLevelEstimator); 40 RTC_DISALLOW_COPY_AND_ASSIGN(PeakLevelEstimator);
33 }; 41 };
34 42
35 } // namespace webrtc 43 } // namespace webrtc
36 44
37 #endif // WEBRTC_MODULES_AUDIO_PROCESSING_LEVEL_CONTROLLER_PEAK_LEVEL_ESTIMATOR _H_ 45 #endif // WEBRTC_MODULES_AUDIO_PROCESSING_LEVEL_CONTROLLER_PEAK_LEVEL_ESTIMATOR _H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698