webrtc/modules/audio_processing/include/audio_processing.cc - Issue 2337083002: Reland of added functionality for specifying the initial signal level to use for the gain estimation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/modules/audio_processing/include/audio_processing.cc

Issue 2337083002: Reland of added functionality for specifying the initial signal level to use for the gain estimation (Closed)

Patch Set: Changes in response to reviewer comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « webrtc/modules/audio_processing/include/audio_processing.h ('k') | webrtc/modules/audio_processing/level_controller/gain_selector.h » ('j') | webrtc/modules/audio_processing/level_controller/level_controller.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.	2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 */	9 */

10	10

(...skipping 15 matching lines...) Expand all Loading...
26 const std::vector<Point>& array_geometry,	26 const std::vector<Point>& array_geometry,

27 SphericalPointf target_direction)	27 SphericalPointf target_direction)

28 : enabled(enabled),	28 : enabled(enabled),

29 array_geometry(array_geometry),	29 array_geometry(array_geometry),

30 target_direction(target_direction) {}	30 target_direction(target_direction) {}

31	31

32 Beamforming::~Beamforming() {}	32 Beamforming::~Beamforming() {}

33	33

34 int AudioProcessing::StartDebugRecordingForPlatformFile(	34 int AudioProcessing::StartDebugRecordingForPlatformFile(

35 rtc::PlatformFile handle) {	35 rtc::PlatformFile handle) {

36 return -1;	36 return -1;
peah-webrtc 2016/09/16 11:36:05 I have now removed the ctor and dtor for the level I have now removed the ctor and dtor for the levelcontroller config. However, I figured it would still make sense to move this file to the same folder as audio_processing.h. WDYT? the sun 2016/09/16 12:40:24 I'm ok with that. Show quoted text On 2016/09/16 11:36:05, peah-webrtc wrote: > I have now removed the ctor and dtor for the levelcontroller config. > > However, I figured it would still make sense to move this file to the same > folder as audio_processing.h. > > WDYT? I'm ok with that. peah-webrtc 2016/09/19 16:37:09 Acknowledged. Show quoted text On 2016/09/16 12:40:24, the sun wrote: > On 2016/09/16 11:36:05, peah-webrtc wrote: > > I have now removed the ctor and dtor for the levelcontroller config. > > > > However, I figured it would still make sense to move this file to the same > > folder as audio_processing.h. > > > > WDYT? > > I'm ok with that. Acknowledged.
37 }	37 }

38	38

	39 AudioProcessing::Config::LevelController::LevelController() = default;

	40 AudioProcessing::Config::LevelController::~LevelController() = default;

	41

39 } // namespace webrtc	42 } // namespace webrtc

OLD	NEW