Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Side by Side Diff: webrtc/modules/audio_processing/level_controller/level_controller.h

Issue 2337083002: Reland of added functionality for specifying the initial signal level to use for the gain estimation (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 20 matching lines...) Expand all
31 31
32 class LevelController { 32 class LevelController {
33 public: 33 public:
34 LevelController(); 34 LevelController();
35 ~LevelController(); 35 ~LevelController();
36 36
37 void Initialize(int sample_rate_hz); 37 void Initialize(int sample_rate_hz);
38 void Process(AudioBuffer* audio); 38 void Process(AudioBuffer* audio);
39 float GetLastGain() { return last_gain_; } 39 float GetLastGain() { return last_gain_; }
40 40
41 // TODO(peah): This method is a temporary solution used to take control
42 // over the parameters in the audio processing module and is likely to change.
the sun 2016/09/14 10:00:59 I don't understand this comment. How do we take co
peah-webrtc 2016/09/16 07:11:07 Totally agree. Done.
43 void ApplyConfig(const AudioProcessing::Config::LevelController& config);
41 // Validates a config. 44 // Validates a config.
42 static bool Validate(const AudioProcessing::Config::LevelController& config); 45 static bool Validate(const AudioProcessing::Config::LevelController& config);
43 // Dumps a config to a string. 46 // Dumps a config to a string.
44 static std::string ToString( 47 static std::string ToString(
45 const AudioProcessing::Config::LevelController& config); 48 const AudioProcessing::Config::LevelController& config);
49 // Sets the initial peak level to use inside the level controller in order
50 // to compute the signal gain. The unit for the peak level is dBFS and
51 // the allowed range is [-100, 0].
52 void SetInitialLevel(float level);
the sun 2016/09/14 10:00:59 Where is this used? The idea of setting up from a
peah-webrtc 2016/09/16 07:11:07 This is a leftover from the former CL. Sorry about
46 53
47 private: 54 private:
48 class Metrics { 55 class Metrics {
49 public: 56 public:
50 Metrics() { Initialize(AudioProcessing::kSampleRate48kHz); } 57 Metrics() { Initialize(AudioProcessing::kSampleRate48kHz); }
51 void Initialize(int sample_rate_hz); 58 void Initialize(int sample_rate_hz);
52 void Update(float long_term_peak_level, 59 void Update(float long_term_peak_level,
53 float noise_level, 60 float noise_level,
54 float gain, 61 float gain,
55 float frame_peak_level); 62 float frame_peak_level);
(...skipping 17 matching lines...) Expand all
73 SignalClassifier signal_classifier_; 80 SignalClassifier signal_classifier_;
74 NoiseLevelEstimator noise_level_estimator_; 81 NoiseLevelEstimator noise_level_estimator_;
75 PeakLevelEstimator peak_level_estimator_; 82 PeakLevelEstimator peak_level_estimator_;
76 SaturatingGainEstimator saturating_gain_estimator_; 83 SaturatingGainEstimator saturating_gain_estimator_;
77 Metrics metrics_; 84 Metrics metrics_;
78 rtc::Optional<int> sample_rate_hz_; 85 rtc::Optional<int> sample_rate_hz_;
79 static int instance_count_; 86 static int instance_count_;
80 float dc_level_[2]; 87 float dc_level_[2];
81 float dc_forgetting_factor_; 88 float dc_forgetting_factor_;
82 float last_gain_; 89 float last_gain_;
90 bool gain_jumpstart_ = false;
83 91
84 RTC_DISALLOW_COPY_AND_ASSIGN(LevelController); 92 RTC_DISALLOW_COPY_AND_ASSIGN(LevelController);
85 }; 93 };
86 94
87 } // namespace webrtc 95 } // namespace webrtc
88 96
89 #endif // WEBRTC_MODULES_AUDIO_PROCESSING_LEVEL_CONTROLLER_LEVEL_CONTROLLER_H_ 97 #endif // WEBRTC_MODULES_AUDIO_PROCESSING_LEVEL_CONTROLLER_LEVEL_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698