Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_receiver.h

Issue 2336213002: Reland of Make rtcp parsing implementation private in RtcpReceiver (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtcp_receiver.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_receiver.h b/webrtc/modules/rtp_rtcp/source/rtcp_receiver.h
index 365937474f78cee0c6c8d4f0cac61edf0895aac0..e9d2c94b7c924db149541950cc938e6ccca375c1 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_receiver.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_receiver.h
@@ -60,13 +60,6 @@
void SetRemoteSSRC(uint32_t ssrc);
uint32_t RemoteSSRC() const;
- int32_t IncomingRTCPPacket(
- RTCPHelp::RTCPPacketInformation& rtcpPacketInformation,
- RTCPUtility::RTCPParserV2* rtcpParser);
-
- void TriggerCallbacksFromRTCPPacket(
- RTCPHelp::RTCPPacketInformation& rtcpPacketInformation);
-
// get received cname
int32_t CNAME(uint32_t remoteSSRC, char cName[RTCP_CNAME_SIZE]) const;
@@ -115,7 +108,21 @@
void RegisterRtcpStatisticsCallback(RtcpStatisticsCallback* callback);
RtcpStatisticsCallback* GetRtcpStatisticsCallback();
- protected:
+ private:
+ using ReceivedInfoMap = std::map<uint32_t, RTCPHelp::RTCPReceiveInformation*>;
+ // RTCP report block information mapped by remote SSRC.
+ using ReportBlockInfoMap =
+ std::map<uint32_t, RTCPHelp::RTCPReportBlockInformation*>;
+ // RTCP report block information map mapped by source SSRC.
+ using ReportBlockMap = std::map<uint32_t, ReportBlockInfoMap>;
+
+ int32_t IncomingRTCPPacket(
+ RTCPHelp::RTCPPacketInformation& rtcpPacketInformation,
+ RTCPUtility::RTCPParserV2* rtcpParser);
+
+ void TriggerCallbacksFromRTCPPacket(
+ RTCPHelp::RTCPPacketInformation& rtcpPacketInformation);
+
RTCPUtility::RTCPCnameInformation* CreateCnameInformation(
uint32_t remoteSSRC);
RTCPUtility::RTCPCnameInformation* GetCnameInformation(
@@ -252,14 +259,6 @@
RTCPUtility::RTCPParserV2* rtcp_parser,
RTCPHelp::RTCPPacketInformation* rtcp_packet_information)
EXCLUSIVE_LOCKS_REQUIRED(_criticalSectionRTCPReceiver);
-
- private:
- typedef std::map<uint32_t, RTCPHelp::RTCPReceiveInformation*> ReceivedInfoMap;
- // RTCP report block information mapped by remote SSRC.
- typedef std::map<uint32_t, RTCPHelp::RTCPReportBlockInformation*>
- ReportBlockInfoMap;
- // RTCP report block information map mapped by source SSRC.
- typedef std::map<uint32_t, ReportBlockInfoMap> ReportBlockMap;
RTCPHelp::RTCPReportBlockInformation* CreateOrGetReportBlockInformation(
uint32_t remote_ssrc,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698