Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2336213002: Reland of Make rtcp parsing implementation private in RtcpReceiver (Closed)

Created:
4 years, 3 months ago by danilchap
Modified:
4 years, 3 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Make rtcp parsing implementation private in RtcpReceiver (patchset #1 id:1 of https://codereview.webrtc.org/2332673003/ ) Reason for revert: Fuzzer changed not use functions moved to private. Original issue's description: > Revert of Make rtcp parsing implementation private in RtcpReceiver (patchset #1 id:1 of https://codereview.webrtc.org/2320603002/ ) > > Reason for revert: > Breaks fuzzer compilation. > > Original issue's description: > > Make rtcp parsing implementation private in RtcpReceiver: > > Function just for Parse and for Callbacks moved to private section. > > All handles moved from protected to private section. > > > > BUG=webrtc:5260 > > R=sprang@webrtc.org > > > > Committed: https://crrev.com/faf708e238c7b43a732fbebf79ac9298b4b95a95 > > Cr-Commit-Position: refs/heads/master@{#14181} > > TBR=sprang@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5260 > > Committed: https://crrev.com/180e4525ca7c9a23602cdf37a8756df7d23e7143 > Cr-Commit-Position: refs/heads/master@{#14182} TBR=sprang@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5260 Committed: https://crrev.com/dd12892ede7139f17355ec4e3a64b3382fcd6f28 Cr-Commit-Position: refs/heads/master@{#14200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 3 chunks +15 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
danilchap
Created Reland of Make rtcp parsing implementation private in RtcpReceiver
4 years, 3 months ago (2016-09-13 10:43:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2336213002/1
4 years, 3 months ago (2016-09-13 10:43:44 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 3 months ago (2016-09-13 12:44:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2336213002/1
4 years, 3 months ago (2016-09-13 19:15:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 19:23:33 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 19:23:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd12892ede7139f17355ec4e3a64b3382fcd6f28
Cr-Commit-Position: refs/heads/master@{#14200}

Powered by Google App Engine
This is Rietveld 408576698