Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2336123002: Revert of Moved webrtc/test/channel_transport/ into webrtc/voice_engine/test/ (Closed)

Created:
4 years, 3 months ago by the sun
Modified:
4 years, 3 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, henrika_webrtc, hlundin-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Moved webrtc/test/channel_transport/ into webrtc/voice_engine/test/ (patchset #7 id:120001 of https://codereview.webrtc.org/2319583005/ ) Reason for revert: Breaks downstream code Original issue's description: > Moved webrtc/test/channel_transport/ into webrtc/voice_engine/test/ > > Only used in VoE tests so I'm moving it in under voice_engine/ until we've removed its usage and can deprecate. > > Note: submitting this with PRESUBMIT=false because the files do not adhere to style guide conventions and I'd rather change that in a separate CL. > > BUG= > NOPRESUBMIT=true > > Committed: https://crrev.com/ade2a038a9290ee0c85d8c682eba5447aca943cd > Cr-Commit-Position: refs/heads/master@{#14191} TBR=kwiberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/07d9e545ff9f3084973d184d714cc8d5d82f1c5b Cr-Commit-Position: refs/heads/master@{#14193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8115 lines, -8111 lines) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/BUILD.gn View 4 chunks +66 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/test/channel_transport/channel_transport.h View 1 chunk +56 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/channel_transport.cc View 1 chunk +83 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/traffic_control_win.h View 1 chunk +99 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/traffic_control_win.cc View 1 chunk +252 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/udp_socket2_manager_win.h View 1 chunk +162 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/udp_socket2_manager_win.cc View 1 chunk +608 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/udp_socket2_win.h View 1 chunk +174 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/udp_socket2_win.cc View 1 chunk +1353 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/udp_socket_manager_posix.h View 1 chunk +88 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/udp_socket_manager_posix.cc View 1 chunk +392 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/udp_socket_manager_unittest.cc View 1 chunk +84 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/udp_socket_manager_wrapper.h View 1 chunk +70 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/udp_socket_manager_wrapper.cc View 1 chunk +72 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/udp_socket_posix.h View 1 chunk +94 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/udp_socket_posix.cc View 1 chunk +271 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/udp_socket_wrapper.h View 1 chunk +112 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/udp_socket_wrapper.cc View 1 chunk +159 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/udp_socket_wrapper_unittest.cc View 1 chunk +67 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/udp_transport.h View 1 chunk +381 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/udp_transport_impl.h View 1 chunk +259 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/udp_transport_impl.cc View 1 chunk +3005 lines, -0 lines 0 comments Download
A webrtc/test/channel_transport/udp_transport_unittest.cc View 1 chunk +143 lines, -0 lines 0 comments Download
M webrtc/test/test.gyp View 3 chunks +53 lines, -0 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 4 chunks +1 line, -66 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_cpu_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_output_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_stress_test.cc View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/voice_engine/test/channel_transport/channel_transport.h View 1 chunk +0 lines, -56 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/channel_transport.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/traffic_control_win.h View 1 chunk +0 lines, -99 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/traffic_control_win.cc View 1 chunk +0 lines, -252 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket2_manager_win.h View 1 chunk +0 lines, -162 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket2_manager_win.cc View 1 chunk +0 lines, -608 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket2_win.h View 1 chunk +0 lines, -174 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket2_win.cc View 1 chunk +0 lines, -1353 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_manager_posix.h View 1 chunk +0 lines, -88 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_manager_posix.cc View 1 chunk +0 lines, -392 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_manager_unittest.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_manager_wrapper.h View 1 chunk +0 lines, -70 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_manager_wrapper.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_posix.h View 1 chunk +0 lines, -94 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_posix.cc View 1 chunk +0 lines, -271 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_wrapper.h View 1 chunk +0 lines, -112 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_wrapper.cc View 1 chunk +0 lines, -159 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_wrapper_unittest.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_transport.h View 1 chunk +0 lines, -381 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_transport_impl.h View 1 chunk +0 lines, -259 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_transport_impl.cc View 1 chunk +0 lines, -3005 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_transport_unittest.cc View 1 chunk +0 lines, -143 lines 0 comments Download
M webrtc/voice_engine/test/cmd_test/voe_cmd_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voice_engine.gyp View 5 chunks +3 lines, -57 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
the sun
Created Revert of Moved webrtc/test/channel_transport/ into webrtc/voice_engine/test/
4 years, 3 months ago (2016-09-13 08:23:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2336123002/1
4 years, 3 months ago (2016-09-13 08:23:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 08:24:06 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 08:24:18 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07d9e545ff9f3084973d184d714cc8d5d82f1c5b
Cr-Commit-Position: refs/heads/master@{#14193}

Powered by Google App Engine
This is Rietveld 408576698