Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 2335683002: Remove a couple of unnecessary dependencies on gflags (Closed)

Created:
4 years, 3 months ago by hlundin-webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove a couple of unnecessary dependencies on gflags BUG=webrtc:5447, chromium:645069 NOTRY=True Committed: https://crrev.com/c26f77f5a6405be355218e6d7dcbd202a72c1f46 Cr-Commit-Position: refs/heads/master@{#14221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
kjellander_webrtc
You haven't Publish+Mail comments on this, is it ready for review? I just noticed it ...
4 years, 3 months ago (2016-09-15 06:05:31 UTC) #4
hlundin-webrtc
On 2016/09/15 06:05:31, kjellander_webrtc wrote: > You haven't Publish+Mail comments on this, is it ready ...
4 years, 3 months ago (2016-09-15 06:56:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2335683002/1
4 years, 3 months ago (2016-09-15 06:56:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 07:04:59 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 07:05:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c26f77f5a6405be355218e6d7dcbd202a72c1f46
Cr-Commit-Position: refs/heads/master@{#14221}

Powered by Google App Engine
This is Rietveld 408576698