This CL renames variables and method and removes some one-line methods inside the APM

This CL renames variables and method and removes some one-line
methods inside the audio processing module for the purpose of
increasing code readability.

BUG=

Committed: https://crrev.com/de65ddc2122470001c85ef15c83bc9d23a7ee8de
Cr-Commit-Position: refs/heads/master@{#14269}

[peah-webrtc, 2016-09-12 12:48:51]

Patchset #1 (id:1) has been deleted

[peah-webrtc, 2016-09-12 12:52:02]

peah@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[peah-webrtc, 2016-09-12 12:52:37]

Description was changed from

==========
This CL renames variables and method and removes some one-line methods inside
the audio processing module for the purpose of increasing code readability.


BUG=
==========

to

==========
This CL renames variables and method and removes some one-line 
methods inside the audio processing module for the purpose of
increasing code readability.


BUG=
==========

[the sun, 2016-09-14 09:40:33]

you should update the method signatures in mock_audio_processing as well, and
prepare to polish downstream code (although it looks like it won't break).

https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.cc:441: 
dd

https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.cc:466: 
dd

https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.cc:468:
private_submodules_->level_controller->Initialize(proc_sample_rate_hz());
why did you change the order of vd and lc?

https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/audio_processing_impl.h (right):

https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.h:52: int
reverse_sample_rate_hz,
me too!

https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.h:320: // because the
forward processing number of channels is mutable and is
forward -> capture

https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.h:337: // because the
fix formatting

[peah-webrtc, 2016-09-16 08:26:23]

On 2016/09/14 09:40:33, the sun wrote:
> you should update the method signatures in mock_audio_processing as well, and
> prepare to polish downstream code (although it looks like it won't break).
> 
>
https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
> File webrtc/modules/audio_processing/audio_processing_impl.cc (right):
> 
>
https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
> webrtc/modules/audio_processing/audio_processing_impl.cc:441: 
> dd
> 
>
https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
> webrtc/modules/audio_processing/audio_processing_impl.cc:466: 
> dd
> 
>
https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
> webrtc/modules/audio_processing/audio_processing_impl.cc:468:
> private_submodules_->level_controller->Initialize(proc_sample_rate_hz());
> why did you change the order of vd and lc?
> 
>
https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
> File webrtc/modules/audio_processing/audio_processing_impl.h (right):
> 
>
https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
> webrtc/modules/audio_processing/audio_processing_impl.h:52: int
> reverse_sample_rate_hz,
> me too!
> 
>
https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
> webrtc/modules/audio_processing/audio_processing_impl.h:320: // because the
> forward processing number of channels is mutable and is
> forward -> capture
> 
>
https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
> webrtc/modules/audio_processing/audio_processing_impl.h:337: // because the
> fix formatting

Thanks for the feedback! Apart from the other changes I included changes in
mock_audio_processing.h into the CL as well.

[peah-webrtc, 2016-09-16 08:26:28]

https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.cc:441: 
On 2016/09/14 09:40:32, the sun wrote:
> dd

Done.

https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.cc:466: 
On 2016/09/14 09:40:32, the sun wrote:
> dd

Done.

https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.cc:468:
private_submodules_->level_controller->Initialize(proc_sample_rate_hz());
On 2016/09/14 09:40:32, the sun wrote:
> why did you change the order of vd and lc?

Sorry, my error. What was even worse was that the level controller was
initialized twice.

Done.

https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/audio_processing_impl.h (right):

https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.h:52: int
reverse_sample_rate_hz,
On 2016/09/14 09:40:32, the sun wrote:
> me too!

Awesome!

Done.

https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.h:320: // because the
forward processing number of channels is mutable and is
On 2016/09/14 09:40:32, the sun wrote:
> forward -> capture

Done.

https://codereview.webrtc.org/2335633002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.h:337: // because the
On 2016/09/14 09:40:32, the sun wrote:
> fix formatting

Ouch. I now did a proper cl format on it.

Done.

[the sun, 2016-09-16 08:34:39]

lgtm

https://codereview.webrtc.org/2335633002/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/2335633002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.cc:1343: 
too much space

https://codereview.webrtc.org/2335633002/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/include/mock_audio_processing.h (right):

https://codereview.webrtc.org/2335633002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/include/mock_audio_processing.h:185: int(int
sample_rate_hz,
capture_ here and elsewhere
use same names as in interface declaration

[peah-webrtc, 2016-09-16 11:43:14]

https://codereview.webrtc.org/2335633002/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/2335633002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.cc:1343: 
On 2016/09/16 08:34:38, the sun wrote:
> too much space

Oups! Thanks!

Done.

https://codereview.webrtc.org/2335633002/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/include/mock_audio_processing.h (right):

https://codereview.webrtc.org/2335633002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/include/mock_audio_processing.h:185: int(int
sample_rate_hz,
On 2016/09/16 08:34:39, the sun wrote:
> capture_ here and elsewhere
> use same names as in interface declaration

Done.

[peah-webrtc, 2016-09-16 12:01:02]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2016-09-16 12:01:02]

The patchset sent to the CQ was uploaded after l-g-t-m from solenberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2335633002/#ps100001 (title:
"Re-adding missing initialization")

[commit-bot: I haz the power, 2016-09-16 12:01:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-16 14:01:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 14:01:38]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[peah-webrtc, 2016-09-16 21:53:58]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2016-09-16 21:54:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-16 22:02:18]

Description was changed from

==========
This CL renames variables and method and removes some one-line 
methods inside the audio processing module for the purpose of
increasing code readability.


BUG=
==========

to

==========
This CL renames variables and method and removes some one-line 
methods inside the audio processing module for the purpose of
increasing code readability.


BUG=
==========

[commit-bot: I haz the power, 2016-09-16 22:02:19]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-09-16 22:02:29]

Description was changed from

==========
This CL renames variables and method and removes some one-line 
methods inside the audio processing module for the purpose of
increasing code readability.


BUG=
==========

to

==========
This CL renames variables and method and removes some one-line
methods inside the audio processing module for the purpose of
increasing code readability.

BUG=

Committed: https://crrev.com/de65ddc2122470001c85ef15c83bc9d23a7ee8de
Cr-Commit-Position: refs/heads/master@{#14269}
==========

[commit-bot: I haz the power, 2016-09-16 22:02:30]

Patchset 5 (id:??) landed as
https://crrev.com/de65ddc2122470001c85ef15c83bc9d23a7ee8de
Cr-Commit-Position: refs/heads/master@{#14269}