Moving webrtc/stats/ into webrtc/api/ to resolve a circular dependency

webrtc/api/peerconnection.cc

Index: webrtc/api/peerconnection.cc
diff --git a/webrtc/api/peerconnection.cc b/webrtc/api/peerconnection.cc
index bdd33d7d371003d15197f10579413fb253421263..ab5cde35aeb8ca4de4729eebeed282c97d79e62d 100644
--- a/webrtc/api/peerconnection.cc
+++ b/webrtc/api/peerconnection.cc
@@ -632,6 +632,7 @@ bool PeerConnection::Initialize(
               configuration.redetermine_role_on_ice_restart))));
 
   stats_.reset(new StatsCollector(this));
+  stats_collector_ = RTCStatsCollector::Create(this);
 
   enable_ice_renomination_ = configuration.enable_ice_renomination;
 
@@ -888,6 +889,12 @@ bool PeerConnection::GetStats(StatsObserver* observer,
   return true;
 }
 
+void PeerConnection::GetRTCStats(
+    const rtc::scoped_refptr<RTCStatsCollectorCallback>& callback) {
+  RTC_DCHECK(stats_collector_);

[nisse-webrtc, 2016/09/13 08:16:40]

Does stats_collector_ have to be a member, created above in Initialize? Is the
callback invoked asynchronously, or can you create a temporary stats collector
just for the duration of this call?

[hbos, 2016/09/13 08:50:37]

You could create it temporary for just a call and it would work but then you
don't get the benefits of caching.

+  stats_collector_->GetStatsReport(callback);
+}
+
 PeerConnectionInterface::SignalingState PeerConnection::signaling_state() {
   return signaling_state_;
 }