Replace a DCHECK with static_assert

Replace a DCHECK with static_assert

This requires marking a bunch of compile-time constants "constexpr"
instead of just "const".

Committed: https://crrev.com/d59d3bb117544f2d4efe9f27d199f440a1da6cb8
Cr-Commit-Position: refs/heads/master@{#14199}

[kwiberg-webrtc, 2016-09-13 09:55:01]

Patchset #1 (id:1) has been deleted

[kwiberg-webrtc, 2016-09-13 09:55:09]

Patchset #1 (id:20001) has been deleted

[kwiberg-webrtc, 2016-09-13 09:55:20]

Patchset #1 (id:40001) has been deleted

[kwiberg-webrtc, 2016-09-13 09:55:31]

Patchset #1 (id:60001) has been deleted

[kwiberg-webrtc, 2016-09-13 09:56:58]

kwiberg@webrtc.org changed reviewers:
+ peah@webrtc.org

[kwiberg-webrtc, 2016-09-13 12:39:18]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[kwiberg-webrtc, 2016-09-13 12:39:18]

This is a follow-up to https://codereview.webrtc.org/2304123002/.

[peah-webrtc, 2016-09-13 12:50:12]

Nice!!!
lgtm

https://codereview.webrtc.org/2335483003/diff/80001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/2335483003/diff/80001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.cc:106: "");
Don't we want a message for the assert?

[kwiberg-webrtc, 2016-09-13 13:11:18]

https://codereview.webrtc.org/2335483003/diff/80001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/2335483003/diff/80001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.cc:106: "");
On 2016/09/13 12:50:12, peah-webrtc wrote:
> Don't we want a message for the assert?

No. If the assert fails, there'll be a compilation error that points to this
source line---that's enough. The second argument to static_assert is almost
never useful. (And indeed, in C++17 you're allowed to omit it.)

[kwiberg-webrtc, 2016-09-13 13:11:29]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-09-13 13:11:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-13 14:49:36]

Committed patchset #1 (id:80001)

[commit-bot: I haz the power, 2016-09-13 14:49:47]

Description was changed from

==========
Replace a DCHECK with static_assert

This requires marking a bunch of compile-time constants "constexpr"
instead of just "const".
==========

to

==========
Replace a DCHECK with static_assert

This requires marking a bunch of compile-time constants "constexpr"
instead of just "const".

Committed: https://crrev.com/d59d3bb117544f2d4efe9f27d199f440a1da6cb8
Cr-Commit-Position: refs/heads/master@{#14199}
==========

[commit-bot: I haz the power, 2016-09-13 14:49:48]

Patchset 1 (id:??) landed as
https://crrev.com/d59d3bb117544f2d4efe9f27d199f440a1da6cb8
Cr-Commit-Position: refs/heads/master@{#14199}