Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: webrtc/modules/desktop_capture/rgba_color.h

Issue 2334853002: Use RgbaColor in DesktopFrameGenerator and add RgbaColorTest (Closed)
Patch Set: Resolve review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 16 matching lines...) Expand all
27 struct RgbaColor final { 27 struct RgbaColor final {
28 // Creates a color with BGRA channels. 28 // Creates a color with BGRA channels.
29 RgbaColor(uint8_t blue, uint8_t green, uint8_t red, uint8_t alpha); 29 RgbaColor(uint8_t blue, uint8_t green, uint8_t red, uint8_t alpha);
30 30
31 // Creates a color with BGR channels, and set alpha channel to 255 (opaque). 31 // Creates a color with BGR channels, and set alpha channel to 255 (opaque).
32 RgbaColor(uint8_t blue, uint8_t green, uint8_t red); 32 RgbaColor(uint8_t blue, uint8_t green, uint8_t red);
33 33
34 // Creates a color from four-byte in BGRA order, i.e. DesktopFrame::data(). 34 // Creates a color from four-byte in BGRA order, i.e. DesktopFrame::data().
35 explicit RgbaColor(const uint8_t* bgra); 35 explicit RgbaColor(const uint8_t* bgra);
36 36
37 // Creates a color from BGRA channels in a uint format. Consumers should make
38 // sure the memory order of the uint32_t is always BGRA from left to right, no
39 // matter the system endian. This function creates an equivalent RgbaColor
40 // instance from the ToUInt32() result of another RgbaColor instance.
41 explicit RgbaColor(uint32_t bgra);
42
37 // Returns true if |this| and |right| is the same color. 43 // Returns true if |this| and |right| is the same color.
38 bool operator==(const RgbaColor& right) const; 44 bool operator==(const RgbaColor& right) const;
39 45
40 // Returns true if |this| and |right| are different colors. 46 // Returns true if |this| and |right| are different colors.
41 bool operator!=(const RgbaColor& right) const; 47 bool operator!=(const RgbaColor& right) const;
42 48
49 uint32_t ToUInt32() const;
50
43 uint8_t blue; 51 uint8_t blue;
44 uint8_t green; 52 uint8_t green;
45 uint8_t red; 53 uint8_t red;
46 uint8_t alpha; 54 uint8_t alpha;
47 }; 55 };
48 static_assert( 56 static_assert(
49 DesktopFrame::kBytesPerPixel == sizeof(RgbaColor), 57 DesktopFrame::kBytesPerPixel == sizeof(RgbaColor),
50 "A pixel in DesktopFrame should be safe to be represented by a RgbaColor"); 58 "A pixel in DesktopFrame should be safe to be represented by a RgbaColor");
51 59
52 } // namespace webrtc 60 } // namespace webrtc
53 61
54 #endif // WEBRTC_MODULES_DESKTOP_CAPTURE_RGBA_COLOR_H_ 62 #endif // WEBRTC_MODULES_DESKTOP_CAPTURE_RGBA_COLOR_H_
OLDNEW
« no previous file with comments | « webrtc/modules/desktop_capture/desktop_frame_generator.cc ('k') | webrtc/modules/desktop_capture/rgba_color.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698