Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: webrtc/modules/desktop_capture/rgba_color.cc

Issue 2334853002: Use RgbaColor in DesktopFrameGenerator and add RgbaColorTest (Closed)
Patch Set: Resolve review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/modules/desktop_capture/rgba_color.h" 11 #include "webrtc/modules/desktop_capture/rgba_color.h"
12 12
13 #include "webrtc/typedefs.h"
14
13 namespace webrtc { 15 namespace webrtc {
14 16
15 namespace { 17 namespace {
16 18
17 bool AlphaEquals(uint8_t i, uint8_t j) { 19 bool AlphaEquals(uint8_t i, uint8_t j) {
18 // On Linux and Windows 8 or early version, '0' was returned for alpha channel 20 // On Linux and Windows 8 or early version, '0' was returned for alpha channel
19 // from capturer APIs, on Windows 10, '255' was returned. So a workaround is 21 // from capturer APIs, on Windows 10, '255' was returned. So a workaround is
20 // to treat 0 as 255. 22 // to treat 0 as 255.
21 return i == j || ((i == 0 || i == 255) && (j == 0 || j == 255)); 23 return i == j || ((i == 0 || i == 255) && (j == 0 || j == 255));
22 } 24 }
23 25
24 } // namespace 26 } // namespace
25 27
26 RgbaColor::RgbaColor(uint8_t blue, uint8_t green, uint8_t red, uint8_t alpha) { 28 RgbaColor::RgbaColor(uint8_t blue, uint8_t green, uint8_t red, uint8_t alpha) {
27 this->blue = blue; 29 this->blue = blue;
28 this->green = green; 30 this->green = green;
29 this->red = red; 31 this->red = red;
30 this->alpha = alpha; 32 this->alpha = alpha;
31 } 33 }
32 34
33 RgbaColor::RgbaColor(uint8_t blue, uint8_t green, uint8_t red) 35 RgbaColor::RgbaColor(uint8_t blue, uint8_t green, uint8_t red)
34 : RgbaColor(blue, green, red, 0xff) {} 36 : RgbaColor(blue, green, red, 0xff) {}
35 37
36 RgbaColor::RgbaColor(const uint8_t* bgra) 38 RgbaColor::RgbaColor(const uint8_t* bgra)
37 : RgbaColor(bgra[0], bgra[1], bgra[2], bgra[3]) {} 39 : RgbaColor(bgra[0], bgra[1], bgra[2], bgra[3]) {}
38 40
41 RgbaColor::RgbaColor(uint32_t bgra)
42 : RgbaColor(reinterpret_cast<uint8_t*>(&bgra)) {}
43
39 bool RgbaColor::operator==(const RgbaColor& right) const { 44 bool RgbaColor::operator==(const RgbaColor& right) const {
40 return blue == right.blue && green == right.green && red == right.red && 45 return blue == right.blue && green == right.green && red == right.red &&
41 AlphaEquals(alpha, right.alpha); 46 AlphaEquals(alpha, right.alpha);
42 } 47 }
43 48
44 bool RgbaColor::operator!=(const RgbaColor& right) const { 49 bool RgbaColor::operator!=(const RgbaColor& right) const {
45 return !(*this == right); 50 return !(*this == right);
46 } 51 }
47 52
53 uint32_t RgbaColor::ToUInt32() const {
54 #if defined(WEBRTC_ARCH_LITTLE_ENDIAN)
55 return blue | (green << 8) | (red << 16) | (alpha << 24);
56 #else
57 return (blue << 24) | (green << 16) | (red << 8) | alpha;
58 #endif
59 }
60
48 } // namespace webrtc 61 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/desktop_capture/rgba_color.h ('k') | webrtc/modules/desktop_capture/rgba_color_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698