Add method cricket::VideoCapturer::NeedsDenoising, use in VideoCapturerTrackSource.

webrtc/api/videocapturertracksource.cc

Index: webrtc/api/videocapturertracksource.cc
diff --git a/webrtc/api/videocapturertracksource.cc b/webrtc/api/videocapturertracksource.cc
index 1bf4bea1d0d779ec93eff06e55b73f1ebd998572..dd9b54872b196303d8c2a1f2b27963d019fe5158 100644
--- a/webrtc/api/videocapturertracksource.cc
+++ b/webrtc/api/videocapturertracksource.cc
@@ -320,6 +320,10 @@ void VideoCapturerTrackSource::Initialize(
     }
   }
 
+  // Get default from the capturer, overridden by constraints, if any.

[pbos-webrtc, 2016/09/12 14:50:45]

Can you add test coverage for this? That would also have caught that there's no
way to override ::NeedsDenoising().

[nisse-webrtc, 2016/09/13 09:39:10]

I can override it in FakeVideoCapturer. But not sure what to test. Maybe it
makes sense to add a unit test in videocapturertracksource that checks that it
is propagated there, to VideoTrackSource::needs_denoising?

[hta-webrtc, 2016/09/13 09:46:27]

Yes, that's a good test - that the value propagates and is consistent with the
request.

A lower priority item-that-needs-doing is to be able to read back the value of
"denoising" - whether it's off or on. This is needed for getSettings().

+  // Note that Chrome no longer uses the webrtc constraints interface.
+  needs_denoising_ = video_capturer_->NeedsDenoising();
+
   if (constraints) {
     MediaConstraintsInterface::Constraints mandatory_constraints =
         constraints->GetMandatory();