Add method cricket::VideoCapturer::NeedsDenoising, use in VideoCapturerTrackSource.

webrtc/media/base/fakevideocapturer.h

 /*
  *  Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 105 matching lines @@
     SignalFrameCaptured(this, &frame);
     return true;
   }
 
   void SignalCapturedFrame(cricket::CapturedFrame* frame) {
     SignalFrameCaptured(this, frame);
   }
 
   sigslot::signal1<FakeVideoCapturer*> SignalDestroyed;
 
-  virtual cricket::CaptureState Start(const cricket::VideoFormat& format) {
+  virtual cricket::CaptureState Start(

[pbos-webrtc, 2016/09/13 14:02:09]

remove virtual (e.g. only use override and not virtual + override), here and
below

[nisse-webrtc, 2016/09/13 14:24:05]

Done, all occurances in this class.

+      const cricket::VideoFormat& format) override {
     cricket::VideoFormat supported;
     if (GetBestCaptureFormat(format, &supported)) {
       SetCaptureFormat(&supported);
     }
     running_ = true;
     SetCaptureState(cricket::CS_RUNNING);
     return cricket::CS_RUNNING;
   }
-  virtual void Stop() {
+  virtual void Stop() override {
     running_ = false;
     SetCaptureFormat(NULL);
     SetCaptureState(cricket::CS_STOPPED);
   }
-  virtual bool IsRunning() { return running_; }
-  virtual bool IsScreencast() const { return is_screencast_; }
-  bool GetPreferredFourccs(std::vector<uint32_t>* fourccs) {
+  virtual bool IsRunning() override { return running_; }
+  virtual bool IsScreencast() const override { return is_screencast_; }
+  rtc::Optional<bool> NeedsDenoising() const override {
+    return needs_denoising_;
+  }
+  bool GetPreferredFourccs(std::vector<uint32_t>* fourccs) override {
     fourccs->push_back(cricket::FOURCC_I420);
     fourccs->push_back(cricket::FOURCC_MJPG);
     return true;
   }
 
   void SetRotation(webrtc::VideoRotation rotation) {
     rotation_ = rotation;
   }
 
   webrtc::VideoRotation GetRotation() { return rotation_; }
 
+  void SetNeedsDenoising(bool needs_denoising) {

[pbos-webrtc, 2016/09/13 14:02:09]

Nit: Imo this should take a rtc::Optional<bool> as argument, it makes it more
obvious in the tests that the needs_denoising argument is actually tri-state
(and makes it posssible to set an unset object).

[nisse-webrtc, 2016/09/13 14:24:05]

Done.

+    needs_denoising_ = rtc::Optional<bool>(needs_denoising);
+  }
+
  private:
   bool running_;
   int64_t initial_timestamp_;
   int64_t next_timestamp_;
   const bool is_screencast_;
+  rtc::Optional<bool> needs_denoising_;
   webrtc::VideoRotation rotation_;
 };
 
 }  // namespace cricket
 
 #endif  // WEBRTC_MEDIA_BASE_FAKEVIDEOCAPTURER_H_