Add method cricket::VideoCapturer::NeedsDenoising, use in VideoCapturerTrackSource.

webrtc/api/videocapturertracksource_unittest.cc

 /*
  *  Copyright 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 426 matching lines @@
   ASSERT_TRUE(source_->is_screencast());
   EXPECT_EQ_WAIT(MediaSourceInterface::kLive, state_observer_->state(),
                  kMaxWaitMs);
   const cricket::VideoFormat* format = capturer_->GetCaptureFormat();
   ASSERT_TRUE(format != NULL);
   EXPECT_EQ(480, format->width);
   EXPECT_EQ(270, format->height);
   EXPECT_EQ(30, format->framerate());
 }
 
+TEST_F(VideoCapturerTrackSourceTest, DenoisingDefault) {
+  CreateVideoCapturerSource();
+  EXPECT_FALSE(source_->needs_denoising());
+}
+
+TEST_F(VideoCapturerTrackSourceTest, DenoisingConstraintOn) {

[pbos-webrtc, 2016/09/13 14:02:09]

I would like a test for constraints overriding the capturer/track option as
well, I believe the constraints should go on top of capturer settings, and it's
OK that they override track defaults.

[nisse-webrtc, 2016/09/13 14:24:05]

Done.

+  FakeConstraints constraints;
+  constraints.AddOptional(MediaConstraintsInterface::kNoiseReduction, true);
+  CreateVideoCapturerSource(&constraints);
+  ASSERT_TRUE(source_->needs_denoising());
+  EXPECT_TRUE(*source_->needs_denoising());
+}
+
+TEST_F(VideoCapturerTrackSourceTest, DenoisingCapturerOff) {
+  capturer_->SetNeedsDenoising(false);
+  CreateVideoCapturerSource();
+  ASSERT_TRUE(source_->needs_denoising());
+  EXPECT_FALSE(*source_->needs_denoising());
+}
+
 TEST_F(VideoCapturerTrackSourceTest, MandatorySubOneFpsConstraints) {
   FakeConstraints constraints;
   constraints.AddMandatory(MediaConstraintsInterface::kMaxFrameRate, 0.5);
 
   CreateVideoCapturerSource(&constraints);
   EXPECT_EQ_WAIT(MediaSourceInterface::kEnded, state_observer_->state(),
                  kMaxWaitMs);
   ASSERT_TRUE(capturer_->GetCaptureFormat() == NULL);
 }
 
 TEST_F(VideoCapturerTrackSourceTest, OptionalSubOneFpsConstraints) {
   FakeConstraints constraints;
   constraints.AddOptional(MediaConstraintsInterface::kMaxFrameRate, 0.5);
 
   CreateVideoCapturerSource(&constraints);
   EXPECT_EQ_WAIT(MediaSourceInterface::kLive, state_observer_->state(),
                  kMaxWaitMs);
   const cricket::VideoFormat* format = capturer_->GetCaptureFormat();
   ASSERT_TRUE(format != NULL);
   EXPECT_EQ(30, format->framerate());
 }