Adding BitrateController to audio network adaptor.

webrtc/modules/BUILD.gn

 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../build/webrtc.gni")
 import("audio_coding/audio_coding.gni")
@@ skipping 218 matching lines @@
   if (is_ios) {
     bundle_data("modules_unittests_bundle_data") {
       testonly = true
       sources = modules_unittests_resources
       outputs = [
         "{{bundle_resources_dir}}/{{source_file_part}}",
       ]
     }
   }
 
+  rtc_source_set("audio_network_adaptor_unittests") {

[hlundin-webrtc, 2016/09/15 11:01:09]

What is the benefit of breaking this out of the modules_unittests?

[minyue-webrtc, 2016/09/15 12:12:15]

the title of patch set 2 mentioned this. To be clearer, this is because
bitrate_controller_unittest.cc exists in modules/bitrate_controller but GN does
not allow this type of collision. GN's suggestion is to put it in a  separate
source set, according to the error message:
"
... either rename one of the files or move one of
the sources to a separate source_set to avoid them both being in
the same target.
"
A separate source_set also looks nicer.

[hlundin-webrtc, 2016/09/19 11:08:57]

Oh, I see. Good. Can you just add a comment explaining this in the gn file?

+    testonly = true
+    sources = [
+      "audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc",
+      "audio_coding/audio_network_adaptor/bitrate_controller_unittest.cc",
+      "audio_coding/audio_network_adaptor/controller_manager_unittest.cc",
+      "audio_coding/audio_network_adaptor/mock/mock_controller.h",
+      "audio_coding/audio_network_adaptor/mock/mock_controller_manager.h",
+    ]
+    deps = [
+      "audio_coding:audio_network_adaptor",
+      "//testing/gmock",
+      "//testing/gtest",
+    ]
+    if (is_clang) {
+      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
+      suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+    }
+  }
+
   rtc_test("modules_unittests") {
     testonly = true
 
     defines = audio_coding_defines
     deps = []
     sources = [
       "audio_coding/acm2/acm_receiver_unittest_oldapi.cc",
       "audio_coding/acm2/audio_coding_module_unittest_oldapi.cc",
       "audio_coding/acm2/call_statistics_unittest.cc",
       "audio_coding/acm2/codec_manager_unittest.cc",
       "audio_coding/acm2/initial_delay_manager_unittest.cc",
       "audio_coding/acm2/rent_a_codec_unittest.cc",
-      "audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc",
-      "audio_coding/audio_network_adaptor/controller_manager_unittest.cc",
-      "audio_coding/audio_network_adaptor/mock/mock_controller.h",
-      "audio_coding/audio_network_adaptor/mock/mock_controller_manager.h",
       "audio_coding/codecs/audio_decoder_factory_unittest.cc",
       "audio_coding/codecs/cng/audio_encoder_cng_unittest.cc",
       "audio_coding/codecs/cng/cng_unittest.cc",
       "audio_coding/codecs/ilbc/ilbc_unittest.cc",
       "audio_coding/codecs/isac/fix/source/filterbanks_unittest.cc",
       "audio_coding/codecs/isac/fix/source/filters_unittest.cc",
       "audio_coding/codecs/isac/fix/source/lpc_masking_model_unittest.cc",
       "audio_coding/codecs/isac/fix/source/transform_unittest.cc",
       "audio_coding/codecs/isac/main/source/audio_encoder_isac_unittest.cc",
       "audio_coding/codecs/isac/main/source/isac_unittest.cc",
@@ skipping 315 matching lines @@
     }
 
     if (is_win) {
       cflags = [
         # TODO(kjellander): bugs.webrtc.org/261: Fix this warning.
         "/wd4373",  # virtual function override.
       ]
     }
 
     deps += [
+      ":audio_network_adaptor_unittests",
       "..:webrtc_common",
       "../base:rtc_base",  # TODO(kjellander): Cleanup in bugs.webrtc.org/3806.
       "../common_audio",
       "../common_video",
       "../system_wrappers:system_wrappers",
       "../test:rtp_test_utils",
       "../test:test_common",
       "../test:test_support_main",
       "../test:test_support_main",
       "../test:video_test_common",
       "audio_coding",
       "audio_coding:acm_receive_test",
       "audio_coding:acm_send_test",
-      "audio_coding:audio_network_adaptor",
       "audio_coding:builtin_audio_decoder_factory",
       "audio_coding:cng",
       "audio_coding:isac_fix",
       "audio_coding:neteq",
       "audio_coding:neteq_test_support",
       "audio_coding:neteq_unittest_tools",
       "audio_coding:pcm16b",
       "audio_coding:red",
       "audio_coding:webrtc_opus",
       "audio_conference_mixer",
@@ skipping 49 matching lines @@
       sources += [
         "audio_device/ios/audio_device_unittest_ios.cc",
         "audio_device/ios/objc/RTCAudioSessionTest.mm",
         "video_coding/codecs/h264/h264_video_toolbox_nalu_unittest.cc",
       ]
 
       ldflags = [ "-ObjC" ]
     }
   }
 }