Update test code to use I420Buffer when writing pixel data.

Update test code to use I420Buffer when writing pixel data.

VideoFrameBuffer and VideoFrame will become immutable.

BUG=webrtc:5921
R=magjed@webrtc.org, phoglund@webrtc.org

Committed: https://crrev.com/280ad1514e44bf6717e5871526dd4632f759eb3d
Cr-Commit-Position: refs/heads/master@{#14249}

[nisse-webrtc, 2016-09-14 12:35:00]

Description was changed from

==========
Use I420Buffer for pixel writing. VideoFrameBuffer and VideoFrame will
become immutable.

BUG=webrtc:5921
==========

to

==========
Use I420Buffer for pixel writing. 

VideoFrameBuffer and VideoFrame will become immutable.
Extracted from cl https://codereview.webrtc.org/2278883002/

BUG=webrtc:5921
==========

[nisse-webrtc, 2016-09-14 12:38:32]

nisse@webrtc.org changed reviewers:
+ palmkvist@webrtc.org, phoglund@webrtc.org

[nisse-webrtc, 2016-09-14 12:38:32]

I have a pretty big cl I'm splitting up, to make review easier and higher
quality. This part includes the changes to webrtc/test/.

This part really begs for a nice helper function to read a single I420 frame
from a FILE* into an I420Buffer. Viktor, is that something you're working on?

[phoglund, 2016-09-14 13:23:45]

This isn't exactly my area, but lgtm

https://codereview.webrtc.org/2333373007/diff/1/webrtc/common_video/libyuv/we...
File webrtc/common_video/libyuv/webrtc_libyuv.cc (right):

https://codereview.webrtc.org/2333373007/diff/1/webrtc/common_video/libyuv/we...
webrtc/common_video/libyuv/webrtc_libyuv.cc:296: (ref_buffer.height() !=
test_buffer.height()))
Nit: indent?

https://codereview.webrtc.org/2333373007/diff/1/webrtc/common_video/libyuv/we...
webrtc/common_video/libyuv/webrtc_libyuv.cc:325: (ref_buffer.height() !=
test_buffer.height()))
Nit: indent?

[nisse-webrtc, 2016-09-14 14:00:40]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-09-14 14:00:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[nisse-webrtc, 2016-09-14 14:06:53]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-09-14 14:06:53]

The patchset sent to the CQ was uploaded after l-g-t-m from phoglund@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2333373007/#ps20001 (title:
"Fix indentation.")

[commit-bot: I haz the power, 2016-09-14 14:07:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[nisse-webrtc, 2016-09-14 14:07:30]

https://codereview.webrtc.org/2333373007/diff/1/webrtc/common_video/libyuv/we...
File webrtc/common_video/libyuv/webrtc_libyuv.cc (right):

https://codereview.webrtc.org/2333373007/diff/1/webrtc/common_video/libyuv/we...
webrtc/common_video/libyuv/webrtc_libyuv.cc:296: (ref_buffer.height() !=
test_buffer.height()))
On 2016/09/14 13:23:45, phoglund wrote:
> Nit: indent?

Done.

https://codereview.webrtc.org/2333373007/diff/1/webrtc/common_video/libyuv/we...
webrtc/common_video/libyuv/webrtc_libyuv.cc:325: (ref_buffer.height() !=
test_buffer.height()))
On 2016/09/14 13:23:45, phoglund wrote:
> Nit: indent?

Done.

[commit-bot: I haz the power, 2016-09-14 14:21:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 14:21:43]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8352)

[nisse-webrtc, 2016-09-15 07:07:24]

Description was changed from

==========
Use I420Buffer for pixel writing. 

VideoFrameBuffer and VideoFrame will become immutable.
Extracted from cl https://codereview.webrtc.org/2278883002/

BUG=webrtc:5921
==========

to

==========
Update test code to use I420Buffer when writing pixel data.

VideoFrameBuffer and VideoFrame will become immutable.

BUG=webrtc:5921
==========

[nisse-webrtc, 2016-09-15 07:08:13]

nisse@webrtc.org changed reviewers:
+ magjed@webrtc.org

[nisse-webrtc, 2016-09-15 07:08:14]

Extracted from cl https://codereview.webrtc.org/2278883002/

Magnus: Owners approval needed for common_video.

[magjed_webrtc, 2016-09-15 13:18:46]

lgtm

https://codereview.webrtc.org/2333373007/diff/40001/webrtc/common_video/libyu...
File webrtc/common_video/libyuv/webrtc_libyuv.cc (right):

https://codereview.webrtc.org/2333373007/diff/40001/webrtc/common_video/libyu...
webrtc/common_video/libyuv/webrtc_libyuv.cc:317: return
I420PSNR(*ref_frame->video_frame_buffer(),
nit: maybe the diff would have been smaller if you declared the new function
under instead. you can also experiment with 'git cl upload --similarity=10'.

[nisse-webrtc, 2016-09-15 13:20:00]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-09-15 13:20:00]

The patchset sent to the CQ was uploaded after l-g-t-m from phoglund@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2333373007/#ps40001 (title:
"Additional size_t -> int casts.")

[commit-bot: I haz the power, 2016-09-15 13:20:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-15 14:06:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 14:06:33]

Try jobs failed on following builders:
  linux_tsan2 on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/15208)

[nisse-webrtc, 2016-09-16 05:58:33]

Spotted a problem, will fix.

https://codereview.webrtc.org/2333373007/diff/40001/webrtc/test/frame_generat...
File webrtc/test/frame_generator.cc (right):

https://codereview.webrtc.org/2333373007/diff/40001/webrtc/test/frame_generat...
webrtc/test/frame_generator.cc:40: static_cast<int>(half_width));
This always keeps the same buffer. That doesn't seem right, even if 
CreateEmptyFrame used to do that a few revisions back, but it had the HasOneRef
hack.

There are also tsan warnings (see
https://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/152...)
due to the constructor and NextFrame being called on separate threads, which
possibly are related to this problem.

I'll fix, and make NextFrame always allocate a new I420Buffer.

[nisse-webrtc, 2016-09-16 07:05:09]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-09-16 07:05:09]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
phoglund@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2333373007/#ps60001 (title:
"Don't reuse frame buffers in ChromaGenerator.")

[commit-bot: I haz the power, 2016-09-16 07:05:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-16 07:07:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 07:07:24]

Try jobs failed on following builders:
  win_clang_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_rel/builds/6418)
  win_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/18158)
  win_x64_gyp_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gyp_dbg/builds/664)

[nisse-webrtc, 2016-09-16 08:07:24]

Description was changed from

==========
Update test code to use I420Buffer when writing pixel data.

VideoFrameBuffer and VideoFrame will become immutable.

BUG=webrtc:5921
==========

to

==========
Update test code to use I420Buffer when writing pixel data.

VideoFrameBuffer and VideoFrame will become immutable.

BUG=webrtc:5921
R=magjed@webrtc.org, phoglund@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/280ad1514e44bf6717e587152...
==========

[nisse-webrtc, 2016-09-16 08:07:25]

Committed patchset #5 (id:80001) manually as
280ad1514e44bf6717e5871526dd4632f759eb3d (presubmit successful).

[commit-bot: I haz the power, 2016-09-16 08:07:29]

Description was changed from

==========
Update test code to use I420Buffer when writing pixel data.

VideoFrameBuffer and VideoFrame will become immutable.

BUG=webrtc:5921
R=magjed@webrtc.org, phoglund@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/280ad1514e44bf6717e587152...
==========

to

==========
Update test code to use I420Buffer when writing pixel data.

VideoFrameBuffer and VideoFrame will become immutable.

BUG=webrtc:5921
R=magjed@webrtc.org, phoglund@webrtc.org

Committed: https://crrev.com/280ad1514e44bf6717e5871526dd4632f759eb3d
Cr-Commit-Position: refs/heads/master@{#14249}
==========

[nisse-webrtc, 2016-09-16 08:31:47]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.webrtc.org/2342123003/ by nisse@webrtc.org.

The reason for reverting is: Fails 64-bit windows builds, it turns out I missed
some of the needed int/size_t casts. Example
https://build.chromium.org/p/client.webrtc/waterfall?builder=Win64%20Release

Hope our windows try bots get back in working shape soon..