Fix issues with rtc_stats_unittests tests so that they can run on bots

webrtc/stats/rtcstats_unittest.cc

Index: webrtc/stats/rtcstats_unittest.cc
diff --git a/webrtc/stats/rtcstats_unittest.cc b/webrtc/stats/rtcstats_unittest.cc
index 1d4e016044dc77dadb55af5f4f1289208629cb8b..2908deba607615aa9483651d92ef4f23c279678d 100644
--- a/webrtc/stats/rtcstats_unittest.cc
+++ b/webrtc/stats/rtcstats_unittest.cc
@@ -10,6 +10,8 @@
 
 #include "webrtc/api/rtcstats.h"
 
+#include <cstring>
+
 #include "webrtc/base/checks.h"
 #include "webrtc/base/gunit.h"
 
@@ -130,7 +132,7 @@ TEST(RTCStatsTest, RTCStatsAndMembers) {
   EXPECT_EQ(*stats.m_int64, static_cast<int64_t>(123));
   EXPECT_EQ(*stats.m_uint64, static_cast<uint64_t>(123));
   EXPECT_EQ(*stats.m_double, 123.0);
-  EXPECT_EQ(*stats.m_static_string, "123");
+  EXPECT_EQ(strcmp(*stats.m_static_string, "123"), 0);

[nisse-webrtc, 2016/09/14 07:53:07]

Makes me think: Do you really need stats using the type const char*? If all
strings can be std::string, that would make things a little simpler. But that's
perhaps best addressed in a different cl.

[hbos, 2016/09/14 08:21:15]

I think you're right, having two different string types seems kind of pointless
(the idea is const strings don't have to be copied into the std::string
container but these should be few and short). I'll remove in a separate CL.

   EXPECT_EQ(*stats.m_string, std::string("123"));
   EXPECT_EQ(*stats.m_sequence_int32, std::vector<int32_t>());
   EXPECT_EQ(*stats.m_sequence_uint32, std::vector<uint32_t>());