Fix issues with rtc_stats_unittests tests so that they can run on bots

webrtc/stats/rtcstats_unittest.cc

 /*
  *  Copyright 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/api/rtcstats.h"
 
+#include <cstring>
+
 #include "webrtc/base/checks.h"
 #include "webrtc/base/gunit.h"
 
 namespace webrtc {
 
 class RTCTestStats : public RTCStats {
  public:
   RTCTestStats(const std::string& id, int64_t timestamp_us)
       : RTCStats(id, timestamp_us),
         m_int32("mInt32"),
@@ skipping 100 matching lines @@
   stats.m_sequence_static_string = std::vector<const char*>();
   stats.m_sequence_string = std::vector<std::string>();
   for (const RTCStatsMemberInterface* member : members) {
     EXPECT_TRUE(member->is_defined());
   }
   EXPECT_EQ(*stats.m_int32, static_cast<int32_t>(123));
   EXPECT_EQ(*stats.m_uint32, static_cast<uint32_t>(123));
   EXPECT_EQ(*stats.m_int64, static_cast<int64_t>(123));
   EXPECT_EQ(*stats.m_uint64, static_cast<uint64_t>(123));
   EXPECT_EQ(*stats.m_double, 123.0);
-  EXPECT_EQ(*stats.m_static_string, "123");
+  EXPECT_EQ(strcmp(*stats.m_static_string, "123"), 0);

[nisse-webrtc, 2016/09/14 07:53:07]

Makes me think: Do you really need stats using the type const char*? If all
strings can be std::string, that would make things a little simpler. But that's
perhaps best addressed in a different cl.

[hbos, 2016/09/14 08:21:15]

I think you're right, having two different string types seems kind of pointless
(the idea is const strings don't have to be copied into the std::string
container but these should be few and short). I'll remove in a separate CL.

   EXPECT_EQ(*stats.m_string, std::string("123"));
   EXPECT_EQ(*stats.m_sequence_int32, std::vector<int32_t>());
   EXPECT_EQ(*stats.m_sequence_uint32, std::vector<uint32_t>());
   EXPECT_EQ(*stats.m_sequence_int64, std::vector<int64_t>());
   EXPECT_EQ(*stats.m_sequence_uint64, std::vector<uint64_t>());
   EXPECT_EQ(*stats.m_sequence_double, std::vector<double>());
   EXPECT_EQ(*stats.m_sequence_static_string, std::vector<const char*>());

[nisse-webrtc, 2016/09/14 07:53:07]

Can you change to non-empty sequences for all these variables, with unique
values? And ensure that you get the correct comparison also for
sequence_static_string.

[hbos, 2016/09/14 08:21:15]

Done.

[nisse-webrtc, 2016/09/14 08:36:42]

Not all, could you add a unique value each also to the other m_sequence_* ? 

[hbos, 2016/09/14 09:42:48]

Oh right, done.

   EXPECT_EQ(*stats.m_sequence_string, std::vector<std::string>());
   int32_t numbers[] = { 4, 8, 15, 16, 23, 42 };
   std::vector<int32_t> numbers_sequence(&numbers[0], &numbers[5]);
   stats.m_sequence_int32->insert(stats.m_sequence_int32->end(),
                                  numbers_sequence.begin(),
                                  numbers_sequence.end());
   EXPECT_EQ(*stats.m_sequence_int32, numbers_sequence);
 }
 
 TEST(RTCStatsTest, RTCStatsGrandChild) {
@@ skipping 24 matching lines @@
 }
 
 TEST(RTCStatsDeathTest, InvalidCasting) {
   RTCGrandChildStats stats("grandchild", 0.0);
   EXPECT_DEATH(stats.cast_to<RTCChildStats>(), "");
 }
 
 #endif  // RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID)
 
 }  // namespace webrtc