Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2332693002: Add printStackTrace method to CameraCapturer. (Closed)

Created:
4 years, 3 months ago by sakal
Modified:
4 years, 3 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add printStackTrace method to CameraCapturer. The method can be used to print the stack trace of the camera thread in error conditions. BUG=webrtc:6148 Committed: https://crrev.com/b3f7876a95d266db68011e47994772a95d6ac97c Cr-Commit-Position: refs/heads/master@{#14187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M webrtc/api/android/java/src/org/webrtc/CameraCapturer.java View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
sakal
PTAL
4 years, 3 months ago (2016-09-12 07:43:47 UTC) #3
magjed_webrtc
lgtm
4 years, 3 months ago (2016-09-12 09:44:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2332693002/1
4 years, 3 months ago (2016-09-12 09:45:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-12 11:45:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2332693002/1
4 years, 3 months ago (2016-09-12 14:14:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 14:35:21 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 14:35:25 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3f7876a95d266db68011e47994772a95d6ac97c
Cr-Commit-Position: refs/heads/master@{#14187}

Powered by Google App Engine
This is Rietveld 408576698