Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2332673003: Revert of Make rtcp parsing implementation private in RtcpReceiver (Closed)

Created:
4 years, 3 months ago by danilchap
Modified:
4 years, 3 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Make rtcp parsing implementation private in RtcpReceiver (patchset #1 id:1 of https://codereview.webrtc.org/2320603002/ ) Reason for revert: Breaks fuzzer compilation. Original issue's description: > Make rtcp parsing implementation private in RtcpReceiver: > Function just for Parse and for Callbacks moved to private section. > All handles moved from protected to private section. > > BUG=webrtc:5260 > R=sprang@webrtc.org > > Committed: https://crrev.com/faf708e238c7b43a732fbebf79ac9298b4b95a95 > Cr-Commit-Position: refs/heads/master@{#14181} TBR=sprang@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5260 Committed: https://crrev.com/180e4525ca7c9a23602cdf37a8756df7d23e7143 Cr-Commit-Position: refs/heads/master@{#14182}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 3 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
danilchap
Created Revert of Make rtcp parsing implementation private in RtcpReceiver
4 years, 3 months ago (2016-09-12 08:40:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2332673003/1
4 years, 3 months ago (2016-09-12 08:40:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 08:40:43 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/180e4525ca7c9a23602cdf37a8756df7d23e7143 Cr-Commit-Position: refs/heads/master@{#14182}
4 years, 3 months ago (2016-09-12 08:40:52 UTC) #6
danilchap
4 years, 3 months ago (2016-09-13 10:43:37 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2336213002/ by danilchap@webrtc.org.

The reason for reverting is: Fuzzer changed not use functions moved to private..

Powered by Google App Engine
This is Rietveld 408576698