Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2332213006: Relaxed unnecessarily stringent thread checking in WebRtcAudioSendStream::OnData(). (Closed)

Created:
4 years, 3 months ago by the sun
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Relaxed unnecessarily stringent thread checking in WebRtcAudioSendStream::OnData(). BUG=webrtc:6345 Committed: https://crrev.com/6fa69c91d6192e242ed2bc70836a4f73132a958b Cr-Commit-Position: refs/heads/master@{#14214}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M webrtc/media/engine/webrtcvoiceengine.cc View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 13 (5 generated)
the sun
4 years, 3 months ago (2016-09-14 07:19:16 UTC) #2
Henrik Grunell WebRTC
lgtm https://codereview.webrtc.org/2332213006/diff/1/webrtc/media/engine/webrtcvoiceengine.cc File webrtc/media/engine/webrtcvoiceengine.cc (left): https://codereview.webrtc.org/2332213006/diff/1/webrtc/media/engine/webrtcvoiceengine.cc#oldcode1273 webrtc/media/engine/webrtcvoiceengine.cc:1273: RTC_DCHECK(!worker_thread_checker_.CalledOnValidThread()); Just for the record: this is not ...
4 years, 3 months ago (2016-09-14 07:27:04 UTC) #3
the sun
On 2016/09/14 07:27:04, Henrik Grunell (webrtc) wrote: > lgtm > > https://codereview.webrtc.org/2332213006/diff/1/webrtc/media/engine/webrtcvoiceengine.cc > File webrtc/media/engine/webrtcvoiceengine.cc ...
4 years, 3 months ago (2016-09-14 07:54:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2332213006/1
4 years, 3 months ago (2016-09-14 07:54:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 3 months ago (2016-09-14 09:55:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2332213006/1
4 years, 3 months ago (2016-09-14 12:53:36 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 13:01:35 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 13:01:43 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6fa69c91d6192e242ed2bc70836a4f73132a958b
Cr-Commit-Position: refs/heads/master@{#14214}

Powered by Google App Engine
This is Rietveld 408576698