Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 2331383005: Use I420Buffer rather than VideoFrameBuffer when writing pixels. (Closed)

Created:
4 years, 3 months ago by nisse-webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use I420Buffer rather than VideoFrameBuffer when writing pixels. Prepares for deleting VideoFrameBuffer::MutableDataY{,U,V}. Android changes extracted from cl https://codereview.webrtc.org/2278883002/. BUG=webrtc:5921 Committed: https://crrev.com/cbae0b475c332c7b31ea7d5ab5ee63e1e2c77791 Cr-Commit-Position: refs/heads/master@{#14213}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -21 lines) Patch
M webrtc/api/android/jni/androidmediadecoder_jni.cc View 2 chunks +14 lines, -20 lines 0 comments Download
M webrtc/api/androidvideotracksource.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
nisse-webrtc
Hi, these are the android changes extracted from cl https://codereview.webrtc.org/2278883002/. Already lgtm:ed by Per and ...
4 years, 3 months ago (2016-09-14 07:18:26 UTC) #2
perkj_webrtc
lgtm
4 years, 3 months ago (2016-09-14 08:48:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2331383005/1
4 years, 3 months ago (2016-09-14 08:49:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 3 months ago (2016-09-14 10:49:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2331383005/1
4 years, 3 months ago (2016-09-14 12:43:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 12:45:10 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 12:45:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbae0b475c332c7b31ea7d5ab5ee63e1e2c77791
Cr-Commit-Position: refs/heads/master@{#14213}

Powered by Google App Engine
This is Rietveld 408576698