PeerConnection[Interface]::GetStats(RTCStatsCollectorCallback*) added.

webrtc/api/BUILD.gn

Index: webrtc/api/BUILD.gn
diff --git a/webrtc/api/BUILD.gn b/webrtc/api/BUILD.gn
index cae9e65d4e0af9d0ce2c9eaa2e4c64bafc0ca372..a0efda2a92ffe995c2ffe29ace9b7acff9cddd83 100644
--- a/webrtc/api/BUILD.gn
+++ b/webrtc/api/BUILD.gn
@@ -84,9 +84,8 @@ rtc_source_set("libjingle_peerconnection") {
     "proxy.h",
     "remoteaudiosource.cc",
     "remoteaudiosource.h",
-    "rtcstats.h",
-    "rtcstats_objects.h",
-    "rtcstatsreport.h",
+    "rtcstatscollector.cc",
+    "rtcstatscollector.h",
     "rtpparameters.h",
     "rtpreceiver.cc",
     "rtpreceiver.h",
@@ -128,6 +127,7 @@ rtc_source_set("libjingle_peerconnection") {
     "../call",
     "../media",
     "../pc",
+    "../stats",
   ]
 
   if (rtc_use_quic) {
@@ -298,6 +298,25 @@ if (is_android && !build_with_chromium) {
   }
 }
 
+# GYP version: webrtc/api/api.gyp:rtc_stats_api
+rtc_source_set("rtc_stats_api") {
+  cflags = []
+  sources = [
+    "stats/rtcstats.h",
+    "stats/rtcstats_objects.h",
+    "stats/rtcstatsreport.h",
+  ]
+
+  if (is_clang) {
+    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
+    suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]

[kjellander_webrtc, 2016/09/14 13:55:27]

For new code, I won't tolerate violating these excellent warnings. Are they hard
to fix?

[hbos, 2016/09/14 18:48:03]

Removed. It's not necessary in the header target, but it is necessary in the
rtc_stats target (there since before this CL). Now that rtc_stats does not
include libjingle_peerconnection stuff this can be addressed. I should do that
in a follow-up CL though because it requires changing a macro used (not simple
enough to do in this CL).

[kjellander_webrtc, 2016/09/15 10:16:37]

Acknowledged.

+  }
+
+  deps = [
+    "../base:rtc_base_approved",
+  ]
+}
+
 if (rtc_include_tests) {
   config("peerconnection_unittests_config") {
     # The warnings below are enabled by default. Since GN orders compiler flags
@@ -336,6 +355,7 @@ if (rtc_include_tests) {
       "peerconnectionfactory_unittest.cc",
       "peerconnectioninterface_unittest.cc",
       "proxy_unittest.cc",
+      "rtcstatscollector_unittest.cc",

[kjellander_webrtc, 2016/09/14 13:55:27]

nit: sort alphabetically.

[hbos, 2016/09/14 18:48:03]

It is sorted.

[kjellander_webrtc, 2016/09/15 10:16:37]

Sorry, I misread rtc/rtp :P

       "rtpsenderreceiver_unittest.cc",
       "statscollector_unittest.cc",
       "test/fakeaudiocapturemodule.cc",