PeerConnection[Interface]::GetStats(RTCStatsCollectorCallback*) added.

webrtc/api/rtcstatscollector_unittest.cc

 /*
  *  Copyright 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
-#include "webrtc/stats/rtcstatscollector.h"
+#include "webrtc/api/rtcstatscollector.h"
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "webrtc/api/jsepsessiondescription.h"
-#include "webrtc/api/rtcstats_objects.h"
-#include "webrtc/api/rtcstatsreport.h"
+#include "webrtc/api/stats/rtcstats_objects.h"

[kjellander_webrtc, 2016/09/14 13:55:27]

Shall we decide on a naming scheme here? Underscore delimiter or not between
words?

[hbos, 2016/09/14 18:48:03]

Sure. I don't use underscores in names (e.g. RTCStatsReport = rtcstatsreport,
not rtc_stats_report). The reason for using underscore here is because the
header contains a set of RTCStats-derived classes (RTCPeerConnectionStats,
RTCCertificateStats, etc). Nothing is actually named RTCStatsObjects. If you
don't like the use of underscore for that I can rename it rtcstatsobjects.

[kjellander_webrtc, 2016/09/15 10:16:37]

Oh well, I guess we don't have a solid convention so that reasoning sounds fine.

+#include "webrtc/api/stats/rtcstatsreport.h"
 #include "webrtc/api/test/mock_datachannel.h"
 #include "webrtc/api/test/mock_peerconnection.h"
 #include "webrtc/api/test/mock_webrtcsession.h"
 #include "webrtc/base/checks.h"
 #include "webrtc/base/fakeclock.h"
 #include "webrtc/base/gunit.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/thread_checker.h"
 #include "webrtc/base/timedelta.h"
 #include "webrtc/base/timeutils.h"
@@ skipping 344 matching lines @@
   rtc::scoped_refptr<FakeRTCStatsCollector> collector_;
 };
 
 TEST_F(RTCStatsCollectorTestWithFakeCollector, ThreadUsageAndResultsMerging) {
   collector_->VerifyThreadUsageAndResultsMerging();
 }
 
 }  // namespace
 
 }  // namespace webrtc