Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2328483002: Revert of Setting up an RTP input fuzzer for NetEq (Closed)

Created:
4 years, 3 months ago by hlundin-webrtc
Modified:
4 years, 3 months ago
Reviewers:
ivoc, kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Setting up an RTP input fuzzer for NetEq (patchset #2 id:20001 of https://codereview.webrtc.org/2315633002/ ) Reason for revert: Broke all Chromium libFuzzer builds https://bugs.chromium.org/p/chromium/issues/detail?id=645069 Original issue's description: > Setting up an RTP input fuzzer for NetEq > > This CL introduces a new fuzzer target neteq_rtp_fuzzer that > manipulates the RTP header fields before inserting the packets into > NetEq. A few helper classes are also introduced. > > BUG=webrtc:5447 > NOTRY=True > > Committed: https://crrev.com/2d273f1e97cd5030ed1686f27ce1118291b66395 > Cr-Commit-Position: refs/heads/master@{#14103} TBR=ivoc@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5447 Committed: https://crrev.com/22c8d5a3e01d7c6c20874038c576d64b15110394 Cr-Commit-Position: refs/heads/master@{#14131}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -313 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/audio_coding/neteq/tools/encode_neteq_input.h View 1 chunk +0 lines, -64 lines 0 comments Download
D webrtc/modules/audio_coding/neteq/tools/encode_neteq_input.cc View 1 chunk +0 lines, -89 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_input.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/test/fuzzers/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
D webrtc/test/fuzzers/neteq_rtp_fuzzer.cc View 1 chunk +0 lines, -140 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hlundin-webrtc
Created Revert of Setting up an RTP input fuzzer for NetEq
4 years, 3 months ago (2016-09-08 12:00:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2328483002/1
4 years, 3 months ago (2016-09-08 12:00:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 12:00:40 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/22c8d5a3e01d7c6c20874038c576d64b15110394 Cr-Commit-Position: refs/heads/master@{#14131}
4 years, 3 months ago (2016-09-08 12:00:48 UTC) #7
kjellander_webrtc
4 years, 3 months ago (2016-09-08 12:48:56 UTC) #8
Message was sent while issue was closed.
On 2016/09/08 12:00:48, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/22c8d5a3e01d7c6c20874038c576d64b15110394
> Cr-Commit-Position: refs/heads/master@{#14131}

lgtm
https://codereview.webrtc.org/2321963002/ should prevent this from happening
again.

Powered by Google App Engine
This is Rietveld 408576698