Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: webrtc/media/base/videosourceinterface.h

Issue 2328333002: New class AdaptedVideoTrackSource. (Closed)
Patch Set: Allow VideoBroadcaster::wants() to be called from any thread. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/base/videosourceinterface.h
diff --git a/webrtc/media/base/videosourceinterface.h b/webrtc/media/base/videosourceinterface.h
index bae02c8d0fc3c453d199aa7853b08ecde299e136..efcc0bfff76702cc6c3b7c3f75a03ce5647bbe3a 100644
--- a/webrtc/media/base/videosourceinterface.h
+++ b/webrtc/media/base/videosourceinterface.h
@@ -18,9 +18,13 @@ namespace rtc {
// VideoSinkWants is used for notifying the source of properties a video frame
// should have when it is delivered to a certain sink.
+
struct VideoSinkWants {
- // Tells the source whether the sink wants frames with rotation applied.
- // By default, any rotation must be applied by the sink.
+ // Tells the source whether the sink wants frames with rotation applied. By
+ // default, any rotation must be applied by the sink. The VideoBroadcaster
perkj_webrtc 2016/09/21 08:59:23 I don't think think the comment about VideoBroadCa
nisse-webrtc 2016/09/21 09:43:59 The intention is to explain what the rotation_appl
+ // class ensures that if a sink sets rotation_applied == true, it will never
+ // receive a frame with pending rotation. Unclear if we want to provide that
+ // guarantee in general.
bool rotation_applied = false;
// Tells the source that the sink only wants black frames.

Powered by Google App Engine
This is Rietveld 408576698