Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: webrtc/media/base/adaptedvideotracksource.h

Issue 2328333002: New class AdaptedVideoTrackSource. (Closed)
Patch Set: Move stats update from OnFrame to AdaptFrame. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/base/adaptedvideotracksource.h
diff --git a/webrtc/media/base/adaptedvideotracksource.h b/webrtc/media/base/adaptedvideotracksource.h
new file mode 100644
index 0000000000000000000000000000000000000000..4752ba26af68ace35372b61a183cf9e5f77d7117
--- /dev/null
+++ b/webrtc/media/base/adaptedvideotracksource.h
@@ -0,0 +1,81 @@
+/*
+ * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_MEDIA_BASE_ADAPTEDVIDEOTRACKSOURCE_H_
+#define WEBRTC_MEDIA_BASE_ADAPTEDVIDEOTRACKSOURCE_H_
+
+#include "webrtc/api/mediastreaminterface.h"
+#include "webrtc/api/notifier.h"
+#include "webrtc/media/base/videoadapter.h"
+#include "webrtc/media/base/videobroadcaster.h"
+
+namespace rtc {
+
+class AdaptedVideoTrackSource
perkj_webrtc 2016/09/20 12:26:10 Can you add a not about how this class should be u
nisse-webrtc 2016/09/20 13:17:47 Done.
+ : public webrtc::Notifier<webrtc::VideoTrackSourceInterface> {
+ public:
+ AdaptedVideoTrackSource();
+
+ // Returns false if no stats are available, e.g, for a remote
+ // source, or a source which has not seen its first frame yet.
+ // Should avoid blocking.
+ bool GetStats(Stats* stats) override;
perkj_webrtc 2016/09/20 12:26:10 All these methods should be made private. An imple
nisse-webrtc 2016/09/20 13:17:47 Done. I'll never get used to this convention.
+
+ // Implements rtc::VideoSourceInterface
+ void AddOrUpdateSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink,
+ const rtc::VideoSinkWants& wants) override;
+ void RemoveSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink) override;
+
+ protected:
+ // Checks the apply_rotation_ flag. If the frame needs rotation, it
+ // will be rotated if it is a plain memory frame, and discarded it
+ // if it is a native frame. (Subclasses producing native frames must
+ // handle applied_rotation themselves).
+ void OnFrame(const cricket::VideoFrame& frame);
+
+ void OnSinkWantsChanged(const rtc::VideoSinkWants& wants);
perkj_webrtc 2016/09/20 12:26:10 private
nisse-webrtc 2016/09/20 13:17:47 Done.
+
+ // Reports the appropriate frame size after adaptation. Returns true
+ // if a frame is wanted. Returns false if there are no interested
+ // sinks, or if the VideoAdapter decides to drop the frame.
+ bool AdaptFrame(int width,
+ int height,
+ int64_t time_us,
+ int* out_width,
+ int* out_height,
+ int* crop_width,
+ int* crop_height,
+ int* crop_x,
+ int* crop_y);
+
+ // Returns the current value of the apply_rotation flag, derived
+ // from the VideoSinkWants of registered sinks. Beware that when
+ // using this method, the value may become stale before it is used.
perkj_webrtc 2016/09/20 12:26:10 mm-ok. the problem is not really appy_rotation()-
+ bool apply_rotation();
+
+ cricket::VideoAdapter* video_adapter() { return &video_adapter_; }
+
+ private:
+ rtc::ThreadChecker thread_checker_;
+
+ cricket::VideoAdapter video_adapter_;
+
+ rtc::CriticalSection apply_rotation_crit_;
+ bool apply_rotation_ GUARDED_BY(apply_rotation_crit_);
+
+ rtc::CriticalSection stats_crit_;
+ rtc::Optional<Stats> stats_ GUARDED_BY(stats_crit_);
+
+ VideoBroadcaster broadcaster_;
+};
+
+} // namespace rtc
+
+#endif // WEBRTC_MEDIA_BASE_ADAPTEDVIDEOTRACKSOURCE_H_

Powered by Google App Engine
This is Rietveld 408576698