Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2327743003: Fix oversized rtp header extension parsing. (Closed)

Created:
4 years, 3 months ago by danilchap
Modified:
4 years, 3 months ago
Reviewers:
brandtr
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix oversized rtp extension parsing. When size of individual one-byte extension span beyound extension block BUG=chromium:645201 R=brandtr@webrtc.org Committed: https://crrev.com/a64a2fbf6d92d18e77f813212905bb5eb89799b5 Cr-Commit-Position: refs/heads/master@{#14183}

Patch Set 1 : Added test to show the issue #

Patch Set 2 : Fix + nits nearby #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_packet.cc View 1 2 chunks +9 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
danilchap
4 years, 3 months ago (2016-09-09 11:37:06 UTC) #2
brandtr
lgtm
4 years, 3 months ago (2016-09-12 07:22:26 UTC) #3
danilchap
4 years, 3 months ago (2016-09-12 09:41:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a64a2fbf6d92d18e77f813212905bb5eb89799b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698