Removing assert error when we fail to create a connection for a ping from an unknown address

Removing assert error when we fail to create a connection for a ping from an unknown address.

It may happen in some legitimate scenarios.
For example a turn port may have had a refresh request timeout, so it won't create a new connection for a ping from an unknown address.

R=deadbeef@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/d5fff5040c691b02486c407c41616c6009483bf1

[honghaiz3, 2016-09-09 21:41:46]

Description was changed from

==========
It might be legitimate that a connection was not created with a ping from
unknown address.
One example is that the turn port had a refresh timeout,
so it won't create new connections.

BUG=
==========

to

==========
It might be legitimate that a connection was not created with a ping from
unknown address.
One example is that the turn port had a refresh timeout,
so it won't create new connections.
==========

[Taylor Brandstetter, 2016-09-09 23:18:21]

deadbeef@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Taylor Brandstetter, 2016-09-09 23:18:21]

lgtm. I'd suggest changing the description to something like:

"Removing assert for when we fail to create a connection for a ping from an
unknown address.

This can happen in some legitimate scenarios, such as..."

So that the title of the commit is clear, and it's separated with whitespace
from the rest of the description.

https://codereview.webrtc.org/2327233002/diff/1/webrtc/p2p/base/p2ptransportc...
File webrtc/p2p/base/p2ptransportchannel.cc (right):

https://codereview.webrtc.org/2327233002/diff/1/webrtc/p2p/base/p2ptransportc...
webrtc/p2p/base/p2ptransportchannel.cc:650: if (!connection) {
nit: Could you add a comment describing the legitimate cases where creating a
connection here will fail?

[honghaiz3, 2016-09-09 23:31:23]

Description was changed from

==========
It might be legitimate that a connection was not created with a ping from
unknown address.
One example is that the turn port had a refresh timeout,
so it won't create new connections.
==========

to

==========
Removing assert error when we fail to create a connection for a ping from an
unknown address. 

It may happen in some legitimate scenarios. 
For example a turn port may have had a refresh request timeout, so it won't
create a new connection for a ping from an unknown address.
==========

[honghaiz3, 2016-09-09 23:35:58]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2016-09-09 23:35:59]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2327233002/#ps20001 (title:
"Add comments")

[commit-bot: I haz the power, 2016-09-09 23:36:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-10 01:36:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 01:36:40]

Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[commit-bot: I haz the power, 2016-09-10 03:48:11]

Description was changed from

==========
Removing assert error when we fail to create a connection for a ping from an
unknown address. 

It may happen in some legitimate scenarios. 
For example a turn port may have had a refresh request timeout, so it won't
create a new connection for a ping from an unknown address.
==========

to

==========
Removing assert error when we fail to create a connection for a ping from an
unknown address.

It may happen in some legitimate scenarios.
For example a turn port may have had a refresh request timeout, so it won't
create a new connection for a ping from an unknown address.

R=deadbeef@webrtc.org

Committed: https://crrev.com/d5fff5040c691b02486c407c41616c6009483bf1
Cr-Commit-Position: refs/heads/master@{#14173}
==========

[honghaiz3, 2016-09-10 03:48:11]

Description was changed from

==========
Removing assert error when we fail to create a connection for a ping from an
unknown address. 

It may happen in some legitimate scenarios. 
For example a turn port may have had a refresh request timeout, so it won't
create a new connection for a ping from an unknown address.
==========

to

==========
Removing assert error when we fail to create a connection for a ping from an
unknown address.

It may happen in some legitimate scenarios.
For example a turn port may have had a refresh request timeout, so it won't
create a new connection for a ping from an unknown address.

R=deadbeef@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/d5fff5040c691b02486c407c4...
==========

[commit-bot: I haz the power, 2016-09-10 03:48:12]

Patchset 2 (id:??) landed as
https://crrev.com/d5fff5040c691b02486c407c41616c6009483bf1
Cr-Commit-Position: refs/heads/master@{#14173}

[honghaiz3, 2016-09-10 03:48:12]

Committed patchset #2 (id:20001) manually as
d5fff5040c691b02486c407c41616c6009483bf1 (presubmit successful).