Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2326523002: Add a DEPS gclient hook to prune corrupt mockito remote. (Closed)

Created:
4 years, 3 months ago by ehmaldonado_webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add a DEPS gclient hook to prune corrupt mockito remote. A third_party remote for third_party/mockito/src is corrupt. Run `git remote prune origin` in the checkout directory before syncing Chromium. Thanks to slan@ for providing this fix. TBR=kjellander@webrtc.org BUG=chromium:644722 NOTRY=True Committed: https://crrev.com/3115b06957d5b8cba5d45cebc301795e94a926ec Cr-Commit-Position: refs/heads/master@{#14138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M DEPS View 1 chunk +11 lines, -0 lines 0 comments Download
M sync_chromium.py View 1 chunk +1 line, -1 line 0 comments Download
A webrtc/build/prune_third_party_mockito_origin.py View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2326523002/1
4 years, 3 months ago (2016-09-08 14:58:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 15:02:10 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3115b06957d5b8cba5d45cebc301795e94a926ec Cr-Commit-Position: refs/heads/master@{#14138}
4 years, 3 months ago (2016-09-08 15:02:17 UTC) #5
kjellander_webrtc
lgtm thanks!
4 years, 3 months ago (2016-09-08 15:18:28 UTC) #6
kjellander_webrtc
4 years, 3 months ago (2016-09-08 17:55:29 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2326473003/ by kjellander@webrtc.org.

The reason for reverting is: Unfortunately this didn't help, so I'm reverting
this to clean things up for now..

Powered by Google App Engine
This is Rietveld 408576698