Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2326253002: Fix a type mistake in NetworkMonitor (Closed)

Created:
4 years, 3 months ago by honghaiz3
Modified:
4 years, 3 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix a type mistake long in c++ is 32 bits. We need 64 bits here. Committed: https://crrev.com/5df5434cef81e17c0bfd9d587d1a344e0486b68f Cr-Commit-Position: refs/heads/master@{#14176}

Patch Set 1 : Fix a type mistake #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/api/android/jni/androidnetworkmonitor_jni.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
honghaiz3
PTAL
4 years, 3 months ago (2016-09-10 05:24:04 UTC) #6
AlexG
lgtm
4 years, 3 months ago (2016-09-10 06:22:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2326253002/20001
4 years, 3 months ago (2016-09-10 21:55:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-10 22:47:56 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-10 22:48:03 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5df5434cef81e17c0bfd9d587d1a344e0486b68f
Cr-Commit-Position: refs/heads/master@{#14176}

Powered by Google App Engine
This is Rietveld 408576698