Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Side by Side Diff: webrtc/modules/audio_coding/codecs/ilbc/ilbc_unittest.cc

Issue 2326003002: Moved codec-specific audio packet splitting into decoders. (Closed)
Patch Set: Fixed types in packet splitting (size_t vs. uint32_t) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 #include "webrtc/modules/audio_coding/codecs/ilbc/audio_decoder_ilbc.h" 12 #include "webrtc/modules/audio_coding/codecs/ilbc/audio_decoder_ilbc.h"
13 #include "webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.h" 13 #include "webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.h"
14 #include "webrtc/modules/audio_coding/codecs/legacy_encoded_audio_frame.h"
14 15
15 namespace webrtc { 16 namespace webrtc {
16 17
17 TEST(IlbcTest, BadPacket) { 18 TEST(IlbcTest, BadPacket) {
18 // Get a good packet. 19 // Get a good packet.
19 AudioEncoderIlbc::Config config; 20 AudioEncoderIlbc::Config config;
20 config.frame_size_ms = 20; // We need 20 ms rather than the default 30 ms; 21 config.frame_size_ms = 20; // We need 20 ms rather than the default 30 ms;
21 // otherwise, all possible values of cb_index[2] 22 // otherwise, all possible values of cb_index[2]
22 // are valid. 23 // are valid.
23 AudioEncoderIlbc encoder(config); 24 AudioEncoderIlbc encoder(config);
(...skipping 23 matching lines...) Expand all
47 decoded_samples.data(), &speech_type)); 48 decoded_samples.data(), &speech_type));
48 49
49 // Decode the good packet. This should work, because the failed decoding 50 // Decode the good packet. This should work, because the failed decoding
50 // should not have left the decoder in a broken state. 51 // should not have left the decoder in a broken state.
51 EXPECT_EQ(static_cast<int>(decoded_samples.size()), 52 EXPECT_EQ(static_cast<int>(decoded_samples.size()),
52 decoder.Decode(packet.data(), packet.size(), encoder.SampleRateHz(), 53 decoder.Decode(packet.data(), packet.size(), encoder.SampleRateHz(),
53 sizeof(int16_t) * decoded_samples.size(), 54 sizeof(int16_t) * decoded_samples.size(),
54 decoded_samples.data(), &speech_type)); 55 decoded_samples.data(), &speech_type));
55 } 56 }
56 57
58 class SplitIlbcTest : public ::testing::TestWithParam<std::pair<int, int> > {
59 protected:
60 virtual void SetUp() {
61 const std::pair<int, int> parameters = GetParam();
62 num_frames_ = parameters.first;
63 frame_length_ms_ = parameters.second;
64 frame_length_bytes_ = (frame_length_ms_ == 20) ? 38 : 50;
65 }
66 size_t num_frames_;
67 int frame_length_ms_;
68 size_t frame_length_bytes_;
69 };
70
71 TEST_P(SplitIlbcTest, NumFrames) {
72 AudioDecoderIlbc decoder;
73 const size_t frame_length_samples = frame_length_ms_ * 8;
74 const auto generate_payload = [] (size_t payload_length_bytes) {
75 rtc::Buffer payload(payload_length_bytes);
76 // Fill payload with increasing integers {0, 1, 2, ...}.
77 for (size_t i = 0; i < payload.size(); ++i) {
78 payload[i] = static_cast<uint8_t>(i);
79 }
80 return payload;
81 };
82
83 const auto results = decoder.ParsePayload(
84 generate_payload(frame_length_bytes_ * num_frames_), 0, true);
85 EXPECT_EQ(num_frames_, results.size());
86
87 size_t frame_num = 0;
88 uint8_t payload_value = 0;
89 for (const auto& result : results) {
90 EXPECT_EQ(frame_length_samples * frame_num, result.timestamp);
91 const LegacyEncodedAudioFrame* frame =
92 static_cast<const LegacyEncodedAudioFrame*>(result.frame.get());
93 const rtc::Buffer& payload = frame->payload();
94 EXPECT_EQ(frame_length_bytes_, payload.size());
95 for (size_t i = 0; i < payload.size(); ++i, ++payload_value) {
96 EXPECT_EQ(payload_value, payload[i]);
97 }
98 ++frame_num;
99 }
100 }
101
102 // Test 1 through 5 frames of 20 and 30 ms size.
103 // Also test the maximum number of frames in one packet for 20 and 30 ms.
104 // The maximum is defined by the largest payload length that can be uniquely
105 // resolved to a frame size of either 38 bytes (20 ms) or 50 bytes (30 ms).
106 INSTANTIATE_TEST_CASE_P(
107 IlbcTest, SplitIlbcTest,
108 ::testing::Values(std::pair<int, int>(1, 20), // 1 frame, 20 ms.
109 std::pair<int, int>(2, 20), // 2 frames, 20 ms.
110 std::pair<int, int>(3, 20), // And so on.
111 std::pair<int, int>(4, 20),
112 std::pair<int, int>(5, 20),
113 std::pair<int, int>(24, 20),
114 std::pair<int, int>(1, 30),
115 std::pair<int, int>(2, 30),
116 std::pair<int, int>(3, 30),
117 std::pair<int, int>(4, 30),
118 std::pair<int, int>(5, 30),
119 std::pair<int, int>(18, 30)));
120
121 // Test too large payload size.
122 TEST(IlbcTest, SplitTooLargePayload) {
123 AudioDecoderIlbc decoder;
124 constexpr size_t kPayloadLengthBytes = 950;
125 const auto results =
126 decoder.ParsePayload(rtc::Buffer(kPayloadLengthBytes), 0, true);
127 EXPECT_TRUE(results.empty());
128 }
129
130 // Payload not an integer number of frames.
131 TEST(IlbcTest, SplitUnevenPayload) {
132 AudioDecoderIlbc decoder;
133 constexpr size_t kPayloadLengthBytes = 39; // Not an even number of frames.
134 const auto results =
135 decoder.ParsePayload(rtc::Buffer(kPayloadLengthBytes), 0, true);
136 EXPECT_TRUE(results.empty());
137 }
138
57 } // namespace webrtc 139 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698