webrtc/base: Use RTC_DCHECK() instead of assert()

webrtc/base/flags.cc

 /*
  *  Copyright 2006 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
+#include "webrtc/base/flags.h"
+
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 
+#include "webrtc/base/checks.h"
 
 #if defined(WEBRTC_WIN)
 #include "webrtc/base/win32.h"
 #include <shellapi.h>
 #endif
 
-#include "webrtc/base/flags.h"
-
 namespace rtc {
 // -----------------------------------------------------------------------------
 // Implementation of Flag
 
 Flag::Flag(const char* file, const char* name, const char* comment,
            Type type, void* variable, FlagValue default__)
     : file_(file),
       name_(name),
       comment_(comment),
       type_(type),
@@ skipping 216 matching lines @@
         argv[j++] = argv[i];
     }
     *argc = j;
   }
 
   // parsed all flags successfully
   return 0;
 }
 
 void FlagList::Register(Flag* flag) {
-  assert(flag != NULL && strlen(flag->name()) > 0);
+  RTC_DCHECK(flag);
+  RTC_DCHECK_GT(strlen(flag->name()), 0u);
   // NOTE: Don't call Lookup() within Register because it accesses the name_
   // of other flags in list_, and if the flags are coming from two different
   // compilation units, the initialization order between them is undefined, and
   // this will trigger an asan initialization-order-fiasco error.
   flag->next_ = list_;
   list_ = flag;
 }
 
 #if defined(WEBRTC_WIN)
 WindowsCommandLineArguments::WindowsCommandLineArguments() {
@@ skipping 20 matching lines @@
   // need to free each string in the array, and then the array.
   for(int i = 0; i < argc_; i++) {
     delete[] argv_[i];
   }
 
   delete[] argv_;
 }
 #endif  // WEBRTC_WIN
 
 }  // namespace rtc