Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2325603002: GN Templates: Introduce rtc_shared_library (Closed)

Created:
4 years, 3 months ago by ehmaldonado_webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN Templates: Introduce rtc_shared_library libjingle_peerconnection_so is not including common_config, which is causing some differences is the defines. We'd like to prevent that happening in the future. NOTRY=True BUG=webrtc:5949 Committed: https://crrev.com/acf9f4785af752d823b7e4e465113f0e8b2c5fd7 Cr-Commit-Position: refs/heads/master@{#14127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M webrtc/api/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/build/webrtc.gni View 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
ehmaldonado_webrtc
4 years, 3 months ago (2016-09-08 10:57:17 UTC) #3
kjellander_webrtc
lgtm, can you make a PR for webrtc.org to add this too?
4 years, 3 months ago (2016-09-08 11:20:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2325603002/20001
4 years, 3 months ago (2016-09-08 11:22:44 UTC) #7
kjellander_webrtc
On 2016/09/08 11:20:22, kjellander_webrtc wrote: > lgtm, > > can you make a PR for ...
4 years, 3 months ago (2016-09-08 11:24:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-08 11:26:39 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 11:26:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/acf9f4785af752d823b7e4e465113f0e8b2c5fd7
Cr-Commit-Position: refs/heads/master@{#14127}

Powered by Google App Engine
This is Rietveld 408576698