Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Unified Diff: webrtc/p2p/base/p2ptransportchannel.cc

Issue 2324853002: Adding logs to track potential cause of not starting port allocation.
Patch Set: Remove the ufrag pwd logging in transportcontroller because they are logged in p2ptransportchannel Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/p2p/base/transportcontroller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/p2ptransportchannel.cc
diff --git a/webrtc/p2p/base/p2ptransportchannel.cc b/webrtc/p2p/base/p2ptransportchannel.cc
index 9f25cd2755e33ae3bb3a91e44fb6b82d2a1dd7a1..fc2a6d9eba413d97f644655777b586112e358c2d 100644
--- a/webrtc/p2p/base/p2ptransportchannel.cc
+++ b/webrtc/p2p/base/p2ptransportchannel.cc
@@ -310,6 +310,9 @@ TransportChannelState P2PTransportChannel::ComputeState() const {
void P2PTransportChannel::SetIceParameters(const IceParameters& ice_params) {
ASSERT(worker_thread_ == rtc::Thread::Current());
+ LOG(LS_INFO) << "Set ICE ufrag: " << ice_params.ufrag
+ << " pwd: " << ice_params.pwd << " on transport "
+ << transport_name();
ice_parameters_ = ice_params;
// Note: Candidate gathering will restart when MaybeStartGathering is next
// called.
@@ -434,6 +437,9 @@ const IceConfig& P2PTransportChannel::config() const {
void P2PTransportChannel::MaybeStartGathering() {
if (ice_parameters_.ufrag.empty() || ice_parameters_.pwd.empty()) {
+ LOG(LS_ERROR) << "Cannot gather candidates because ICE parameters are empty"
+ << " ufrag: " << ice_parameters_.ufrag
+ << " pwd: " << ice_parameters_.pwd;
return;
}
// Start gathering if we never started before, or if an ICE restart occurred.
« no previous file with comments | « no previous file | webrtc/p2p/base/transportcontroller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698