Avoids crash at device switch on iOS

Avoids crash at device switch on iOS by ensuring that audio parameters can be updated on the fly driven by e.g. switching audio device.

R=henrikg@webrtc.org

Committed: https://crrev.com/073378e79a8b0c2dc0c257169a0e126d77a28c8f
Cr-Commit-Position: refs/heads/master@{#14158}

[henrika_webrtc, 2016-09-09 09:32:36]

Description was changed from

==========
Avoids crash at device switch on iOS

BUG=
==========

to

==========
Avoids crash at device switch on iOS.
==========

[henrika_webrtc, 2016-09-09 09:32:36]

henrika@webrtc.org changed reviewers:
+ henrikg@webrtc.org

[henrika_webrtc, 2016-09-09 09:54:23]

Description was changed from

==========
Avoids crash at device switch on iOS.
==========

to

==========
Avoids crash at device switch on iOS by ensuring that audio parameters can be
updated on the fly driven by e.g. switching audio device.
==========

[Henrik Grunell WebRTC, 2016-09-09 10:03:30]

lgtm

https://codereview.webrtc.org/2324113002/diff/1/webrtc/modules/audio_device/a...
File webrtc/modules/audio_device/audio_device_buffer.cc (right):

https://codereview.webrtc.org/2324113002/diff/1/webrtc/modules/audio_device/a...
webrtc/modules/audio_device/audio_device_buffer.cc:125: rec_sample_rate_ = fsHz;
Nit: Would be nice with a CHECK for allowed sample rates.

https://codereview.webrtc.org/2324113002/diff/1/webrtc/modules/audio_device/a...
webrtc/modules/audio_device/audio_device_buffer.cc:242:
UpdateRecordingParameters();
As discussed offline, better to only update when needed. But since this is
essentially a revert of a piece of a CL that caused the crash, I'm fine with it.

[henrika_webrtc, 2016-09-09 10:06:36]

Thanks. Fixed.

[henrika_webrtc, 2016-09-09 10:07:48]

The CQ bit was checked by henrika@webrtc.org

[henrika_webrtc, 2016-09-09 10:07:48]

The patchset sent to the CQ was uploaded after l-g-t-m from henrikg@webrtc.org
Link to the patchset: https://codereview.chromium.org/2324113002/#ps40001
(title: "Feedback from grunell@")

[commit-bot: I haz the power, 2016-09-09 10:07:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[Henrik Grunell WebRTC, 2016-09-09 10:19:30]

https://codereview.webrtc.org/2324113002/diff/40001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/audio_device_buffer.cc (right):

https://codereview.webrtc.org/2324113002/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/audio_device_buffer.cc:356:
RTC_DCHECK_LE(play_bytes_per_10ms_, kMaxBufferSizeBytes);
Nit: I think it should even be a CHECK (not DCHECK), since if it's not fulfilled
we'll read oob. Same below. We never checked this before though, so feel free to
change now or when the follow-up for dynamic change of buffer size is written.

[henrika_webrtc, 2016-09-09 10:43:03]

Thanks. Would like to avoid making that small change now when we are in CQ. 
As discussed, will improve in upcoming changes.

[henrika_webrtc, 2016-09-09 11:15:24]

Seems like some bots are delayed. Landing manually.

[henrika_webrtc, 2016-09-09 11:15:51]

Description was changed from

==========
Avoids crash at device switch on iOS by ensuring that audio parameters can be
updated on the fly driven by e.g. switching audio device.
==========

to

==========
Avoids crash at device switch on iOS by ensuring that audio parameters can be
updated on the fly driven by e.g. switching audio device.

R=henrikg@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/073378e79a8b0c2dc0c257169...
==========

[henrika_webrtc, 2016-09-09 11:15:53]

Committed patchset #3 (id:40001) manually as
073378e79a8b0c2dc0c257169a0e126d77a28c8f (presubmit successful).

[commit-bot: I haz the power, 2016-09-09 11:15:55]

Description was changed from

==========
Avoids crash at device switch on iOS by ensuring that audio parameters can be
updated on the fly driven by e.g. switching audio device.

R=henrikg@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/073378e79a8b0c2dc0c257169...
==========

to

==========
Avoids crash at device switch on iOS by ensuring that audio parameters can be
updated on the fly driven by e.g. switching audio device.

R=henrikg@webrtc.org

Committed: https://crrev.com/073378e79a8b0c2dc0c257169a0e126d77a28c8f
Cr-Commit-Position: refs/heads/master@{#14158}
==========