Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2323843002: Revert of remove all reference to carbon api (Closed)

Created:
4 years, 3 months ago by kthelgason
Modified:
4 years, 3 months ago
Reviewers:
magjed_webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, sakal
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of move all reference to carbon api (patchset #2 id:300001 of https://codereview.webrtc.org/2321493002/ ) Reason for revert: Issues have now really been fixed Original issue's description: > Reland of move all reference to carbon api (patchset #1 id:1 of https://codereview.webrtc.org/2316563002/ ) > > Reason for revert: > Chromium build issues have been resolved. > > Original issue's description: > > Revert of Remove all reference to carbon api (patchset #2 id:20001 of https://codereview.webrtc.org/2299633002/ ) > > > > Reason for revert: > > Breaks chromium build > > > > Original issue's description: > > > Remove all reference to carbon api > > > > > > BUG=webrtc:6282 > > > > > > Committed: https://crrev.com/dbd8b6bec4143c940b2f2ca8cd85c25d17327964 > > > Cr-Commit-Position: refs/heads/master@{#14080} > > > > TBR=magjed@webrtc.org,mflodman@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:6282 > > > > Committed: https://crrev.com/b096aa7fd375a980daab3a986596548ca5de2a1c > > Cr-Commit-Position: refs/heads/master@{#14081} > > TBR=magjed@webrtc.org,mflodman@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6282 > > Committed: https://crrev.com/a90879b64fd8db57c0274169311d6b51dd59f1a0 > Cr-Commit-Position: refs/heads/master@{#14125} TBR=magjed@webrtc.org,mflodman@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6282

Patch Set 1 #

Patch Set 2 : rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -895 lines) Patch
M webrtc/BUILD.gn View 1 2 chunks +0 lines, -7 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 4 chunks +1 line, -8 lines 0 comments Download
A + webrtc/base/applefilesystem.mm View 1 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/base/base.gyp View 1 4 chunks +1 line, -19 lines 0 comments Download
D webrtc/base/iosfilesystem.mm View 1 1 chunk +0 lines, -53 lines 0 comments Download
M webrtc/base/macsocketserver.h View 1 2 chunks +1 line, -58 lines 0 comments Download
M webrtc/base/macsocketserver.cc View 1 1 chunk +0 lines, -171 lines 0 comments Download
M webrtc/base/macsocketserver_unittest.cc View 1 2 chunks +0 lines, -74 lines 0 comments Download
M webrtc/base/macutils.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M webrtc/base/macutils.cc View 1 3 chunks +2 lines, -79 lines 0 comments Download
M webrtc/base/macutils_unittest.cc View 1 1 chunk +0 lines, -19 lines 0 comments Download
M webrtc/base/macwindowpicker.cc View 1 1 chunk +1 line, -68 lines 0 comments Download
M webrtc/base/proxydetect.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M webrtc/base/unixfilesystem.cc View 1 6 chunks +14 lines, -37 lines 0 comments Download
M webrtc/engine_configurations.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/BUILD.gn View 1 1 chunk +0 lines, -11 lines 0 comments Download
D webrtc/media/devices/carbonvideorenderer.h View 1 1 chunk +0 lines, -56 lines 0 comments Download
D webrtc/media/devices/carbonvideorenderer.cc View 1 1 chunk +0 lines, -173 lines 0 comments Download
M webrtc/media/devices/videorendererfactory.h View 1 2 chunks +0 lines, -12 lines 0 comments Download
M webrtc/media/media.gyp View 1 1 chunk +0 lines, -18 lines 0 comments Download
M webrtc/modules/desktop_capture/mac/desktop_configuration.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
kthelgason
4 years, 3 months ago (2016-09-08 16:45:02 UTC) #1
Created Revert of move all reference to carbon api

Powered by Google App Engine
This is Rietveld 408576698