Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 2322983002: Add sakal as an OWNER to some Android files. (Closed)

Created:
4 years, 3 months ago by sakal
Modified:
4 years, 3 months ago
Reviewers:
magjed_webrtc, tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add sakal as an OWNER to some Android files. I have written a large part of the code in these files and I feel I should be an OWNER of them. NOTRY=True Committed: https://crrev.com/961168a6dbfa501bd26f1c9d6eb59552a01e7c57 Cr-Commit-Position: refs/heads/master@{#14148}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M webrtc/api/android/java/src/org/webrtc/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/api/android/jni/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
sakal
PTAL
4 years, 3 months ago (2016-09-08 14:00:31 UTC) #4
magjed_webrtc
lgtm
4 years, 3 months ago (2016-09-08 14:07:44 UTC) #6
tommi
lgtm
4 years, 3 months ago (2016-09-08 21:04:25 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2320473002 Patch 80001). Please resolve the dependency and ...
4 years, 3 months ago (2016-09-08 21:04:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2322983002/20001
4 years, 3 months ago (2016-09-09 07:14:14 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 07:22:28 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 07:22:41 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/961168a6dbfa501bd26f1c9d6eb59552a01e7c57
Cr-Commit-Position: refs/heads/master@{#14148}

Powered by Google App Engine
This is Rietveld 408576698